From: Thomas Huth <thuth@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls
Date: Mon, 15 Feb 2016 11:37:19 +0100 [thread overview]
Message-ID: <56C1AA5F.3020608@redhat.com> (raw)
In-Reply-To: <20160212003116.GB2732@voom.fritz.box>
[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]
On 12.02.2016 01:31, David Gibson wrote:
> On Thu, Feb 11, 2016 at 01:47:17PM +0100, Thomas Huth wrote:
>> While we were recently debugging a problem with the H_SET_DABR
>> call [1], I noticed that some hypercalls from the chapter 14.5.4.3
>> ("Processor Register Hypervisor Resource Access") from the LoPAPR
>> spec [2] are still missing in QEMU.
>> So here's are some patches that implement these hypercalls. Linux
>> apparently does not depend on these hypercalls yet (otherwise somebody
>> would have noticed this earlier), but the hypercalls are rather simple,
>> so I think the implementations are quite straight-forward and easy to
>> read.
>>
>> v2:
>> - Don't use set_spr() and set cpu->env.spr[] directly instead
>> - Completely reworked the H_PAGE_INIT patch to map the source
>> and target pages for higher speed, and to be able to flush now
>> the caches if requested.
>
> I've merged 1-3 into ppc-for-2.6. My only concern with those is
> whether we need to be setting some extra flags in the ibm,hypertas
> property now that they are implemented.
Good point, ... looking at "Table 176. Hypervisor Call Function Table"
in LoPAPR, it seems like there are indeed additional function sets that
should be signaled with this property. But the current list seems to be
in a bad shape, anyway, e.g. "hcall-debug" seems to be missing for the
H_LOGICAL_CI_LOAD/STORE function. So I think we best fix this up with a
separate patch later (I can submit one once I sorted out the H_PAGE_INIT
patch).
Thomas
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2016-02-15 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 12:47 [Qemu-devel] [PATCH v2 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls Thomas Huth
2016-02-11 12:47 ` [Qemu-devel] [PATCH v2 1/4] hw/ppc/spapr: Add h_set_sprg0 hypercall Thomas Huth
2016-02-11 12:47 ` [Qemu-devel] [PATCH v2 2/4] hw/ppc/spapr: Implement h_set_dabr Thomas Huth
2016-02-11 12:47 ` [Qemu-devel] [PATCH v2 3/4] hw/ppc/spapr: Implement the h_set_xdabr hypercall Thomas Huth
2016-02-11 12:47 ` [Qemu-devel] [PATCH v2 4/4] hw/ppc/spapr: Implement the h_page_init hypercall Thomas Huth
2016-02-12 0:43 ` David Gibson
2016-02-12 0:31 ` [Qemu-devel] [PATCH v2 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls David Gibson
2016-02-15 10:37 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1AA5F.3020608@redhat.com \
--to=thuth@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).