From: "Cédric Le Goater" <clg@fr.ibm.com>
To: marcel@redhat.com, Corey Minyard <cminyard@mvista.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Greg Kurz <gkurz@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/8] ipmi: use a function to initialize the SDR table
Date: Mon, 15 Feb 2016 17:52:54 +0100 [thread overview]
Message-ID: <56C20266.2090501@fr.ibm.com> (raw)
In-Reply-To: <56C03B68.3050408@gmail.com>
On 02/14/2016 09:31 AM, Marcel Apfelbaum wrote:
> On 02/09/2016 02:13 PM, Cédric Le Goater wrote:
>> This patch does not change anything.
>
> Hi,
>
> Well, it changes *something*, otherwise ... :)
>
> Maybe "This is only a re-factoring."
Yes. This is much better. "does not change anything" doe not make sense ...
C.
>
>
>
> It only moves the code section
>> initializing the sdrs in its own routine and prepares ground for the
>> subsequent patches.
>>
>> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
>> ---
>> hw/ipmi/ipmi_bmc_sim.c | 49 ++++++++++++++++++++++++++++---------------------
>> 1 file changed, 28 insertions(+), 21 deletions(-)
>>
>> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
>> index 13171336f7f1..0abc9cb5de94 100644
>> --- a/hw/ipmi/ipmi_bmc_sim.c
>> +++ b/hw/ipmi/ipmi_bmc_sim.c
>> @@ -1703,6 +1703,33 @@ static const uint8_t init_sdrs[] = {
>> 0xff, 0xff, 0x00, 0x00, 0x00
>> };
>>
>> +static void ipmi_sdr_init(IPMIBmcSim *ibs)
>> +{
>> + unsigned int i;
>> + unsigned int recid;
>> +
>> + for (i = 0;;) {
>
>
> I am all for extracting the functionality in a function,
> what bothers me a little is the above construct.
>
> Maybe you can find a more "standard: approach like:
>
> while (recid != 0xffff) {
> ...
> }
>
> Or maybe is just me.
>
> Thanks,
> Marcel
>
>> + struct ipmi_sdr_header *sdrh;
>> + int len;
>> + if ((i + IPMI_SDR_HEADER_SIZE) > sizeof(init_sdrs)) {
>> + error_report("Problem with recid 0x%4.4x", i);
>> + return;
>> + }
>> + sdrh = (struct ipmi_sdr_header *) &init_sdrs[i];
>> + len = ipmi_sdr_length(sdrh);
>> + recid = ipmi_sdr_recid(sdrh);
>> + if (recid == 0xffff) {
>> + break;
>> + }
>> + if ((i + len) > sizeof(init_sdrs)) {
>> + error_report("Problem with recid 0x%4.4x", i);
>> + return;
>> + }
>> + sdr_add_entry(ibs, sdrh, len, NULL);
>> + i += len;
>> + }
>> +}
>> +
>> static const VMStateDescription vmstate_ipmi_sim = {
>> .name = TYPE_IPMI_BMC_SIMULATOR,
>> .version_id = 1,
>> @@ -1735,7 +1762,6 @@ static void ipmi_sim_realize(DeviceState *dev, Error **errp)
>> {
>> IPMIBmc *b = IPMI_BMC(dev);
>> unsigned int i;
>> - unsigned int recid;
>> IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b);
>>
>> qemu_mutex_init(&ibs->lock);
>> @@ -1752,26 +1778,7 @@ static void ipmi_sim_realize(DeviceState *dev, Error **errp)
>> ibs->sdr.last_clear[i] = 0xff;
>> }
>>
>> - for (i = 0;;) {
>> - struct ipmi_sdr_header *sdrh;
>> - int len;
>> - if ((i + IPMI_SDR_HEADER_SIZE) > sizeof(init_sdrs)) {
>> - error_report("Problem with recid 0x%4.4x", i);
>> - return;
>> - }
>> - sdrh = (struct ipmi_sdr_header *) &init_sdrs[i];
>> - len = ipmi_sdr_length(sdrh);
>> - recid = ipmi_sdr_recid(sdrh);
>> - if (recid == 0xffff) {
>> - break;
>> - }
>> - if ((i + len) > sizeof(init_sdrs)) {
>> - error_report("Problem with recid 0x%4.4x", i);
>> - return;
>> - }
>> - sdr_add_entry(ibs, sdrh, len, NULL);
>> - i += len;
>> - }
>> + ipmi_sdr_init(ibs);
>>
>> ibs->acpi_power_state[0] = 0;
>> ibs->acpi_power_state[1] = 0;
>>
>
next prev parent reply other threads:[~2016-02-15 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 12:13 [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2) Cédric Le Goater
2016-02-09 12:13 ` [Qemu-devel] [PATCH 1/8] ipmi: add a realize function to the device class Cédric Le Goater
2016-02-14 8:22 ` Marcel Apfelbaum
2016-02-09 12:13 ` [Qemu-devel] [PATCH 2/8] ipmi: use a function to initialize the SDR table Cédric Le Goater
2016-02-14 8:31 ` Marcel Apfelbaum
2016-02-15 16:52 ` Cédric Le Goater [this message]
2016-02-09 12:13 ` [Qemu-devel] [PATCH 3/8] ipmi: remove the need of an ending record in " Cédric Le Goater
2016-02-14 8:39 ` Marcel Apfelbaum
2016-02-09 12:13 ` [Qemu-devel] [PATCH 4/8] ipmi: add some local variables in ipmi_sdr_init Cédric Le Goater
2016-02-14 8:55 ` Marcel Apfelbaum
2016-02-15 16:54 ` Cédric Le Goater
2016-02-09 12:13 ` [Qemu-devel] [PATCH 5/8] ipmi: use a file to load SDRs Cédric Le Goater
2016-02-14 9:08 ` Marcel Apfelbaum
2016-02-15 17:02 ` Cédric Le Goater
2016-02-09 12:13 ` [Qemu-devel] [PATCH 6/8] ipmi: provide support for FRUs Cédric Le Goater
2016-02-14 9:25 ` Marcel Apfelbaum
2016-02-15 17:17 ` Cédric Le Goater
2016-02-15 18:40 ` Marcel Apfelbaum
2016-02-16 3:38 ` Corey Minyard
2016-02-16 8:47 ` Cédric Le Goater
2016-02-09 12:13 ` [Qemu-devel] [PATCH 7/8] ipmi: introduce an ipmi_bmc_sdr_find() API Cédric Le Goater
2016-02-14 9:30 ` Marcel Apfelbaum
2016-02-15 17:21 ` Cédric Le Goater
2016-02-09 12:13 ` [Qemu-devel] [PATCH 8/8] ipmi: introduce an ipmi_bmc_gen_event() API Cédric Le Goater
2016-02-14 9:32 ` Marcel Apfelbaum
2016-02-09 18:25 ` [Qemu-devel] [PATCH 0/8] ipmi: a couple of enhancements to the BMC simulator (round 2) Corey Minyard
2016-02-10 14:05 ` Cédric Le Goater
2016-02-10 16:06 ` Corey Minyard
2016-02-10 16:13 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C20266.2090501@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=cminyard@mvista.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).