From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVMqB-0007sp-WC for qemu-devel@nongnu.org; Mon, 15 Feb 2016 12:21:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVMq8-0007Wr-P3 for qemu-devel@nongnu.org; Mon, 15 Feb 2016 12:21:39 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:40872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVMq8-0007Wd-F0 for qemu-devel@nongnu.org; Mon, 15 Feb 2016 12:21:36 -0500 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 15 Feb 2016 17:21:34 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2639E1B08061 for ; Mon, 15 Feb 2016 17:21:49 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1FHLXTr36306978 for ; Mon, 15 Feb 2016 17:21:33 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1FHLWsb022138 for ; Mon, 15 Feb 2016 10:21:32 -0700 References: <1455020010-17532-1-git-send-email-clg@fr.ibm.com> <1455020010-17532-8-git-send-email-clg@fr.ibm.com> <56C04923.2020108@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <56C2091A.3030300@fr.ibm.com> Date: Mon, 15 Feb 2016 18:21:30 +0100 MIME-Version: 1.0 In-Reply-To: <56C04923.2020108@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 7/8] ipmi: introduce an ipmi_bmc_sdr_find() API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcel@redhat.com, Corey Minyard Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Greg Kurz On 02/14/2016 10:30 AM, Marcel Apfelbaum wrote: > On 02/09/2016 02:13 PM, Cédric Le Goater wrote: >> This patch exposes a new IPMI routine to query a sdr entry from the >> sdr table maintained by the IPMI BMC simulator. The API is very >> similar to the internal sdr_find_entry() routine and should be used >> the same way to query one or all sdrs. >> >> A typical use would be to loop on the sdrs to build nodes of a device >> tree. >> >> Signed-off-by: Cédric Le Goater >> --- >> hw/ipmi/ipmi_bmc_sim.c | 16 ++++++++++++++++ >> include/hw/ipmi/ipmi.h | 2 ++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c >> index b0754893fc08..c952219429f4 100644 >> --- a/hw/ipmi/ipmi_bmc_sim.c >> +++ b/hw/ipmi/ipmi_bmc_sim.c >> @@ -406,6 +406,22 @@ static int sdr_find_entry(IPMISdr *sdr, uint16_t recid, >> return 1; >> } >> >> +int ipmi_bmc_sdr_find(IPMIBmc *b, uint16_t recid, >> + const struct ipmi_sdr_compact **sdr, uint16_t *nextrec) >> + >> +{ >> + IPMIBmcSim *ibs = IPMI_BMC_SIMULATOR(b); >> + unsigned int pos; >> + >> + pos = 0; >> + if (sdr_find_entry(&ibs->sdr, recid, &pos, nextrec)) { >> + return -1; >> + } >> + >> + *sdr = (const struct ipmi_sdr_compact *) &ibs->sdr.sdr[pos]; >> + return 0; >> +} >> + >> static void sel_inc_reservation(IPMISel *sel) >> { >> sel->reservation++; >> diff --git a/include/hw/ipmi/ipmi.h b/include/hw/ipmi/ipmi.h >> index 74a2b5af9613..e41321db174d 100644 >> --- a/include/hw/ipmi/ipmi.h >> +++ b/include/hw/ipmi/ipmi.h >> @@ -255,4 +255,6 @@ struct ipmi_sdr_compact { >> >> typedef uint8_t ipmi_sdr_compact_buffer[sizeof(struct ipmi_sdr_compact)]; >> >> +int ipmi_bmc_sdr_find(IPMIBmc *b, uint16_t recid, >> + const struct ipmi_sdr_compact **sdr, uint16_t *nextrec); > > This method is not used yet. I suppose you have a work in progress > using it, I suggest to add this to your next series when it will be used. OK. I will do. Thanks, C. > Thanks, > Marcel > >> #endif >> >