From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWFYk-0005sp-8J for qemu-devel@nongnu.org; Wed, 17 Feb 2016 22:47:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWFYg-0002i8-Ia for qemu-devel@nongnu.org; Wed, 17 Feb 2016 22:47:18 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:43829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWFYf-0002g1-Ke for qemu-devel@nongnu.org; Wed, 17 Feb 2016 22:47:14 -0500 References: <1454750932-7556-1-git-send-email-zhang.zhanghailiang@huawei.com> <1454750932-7556-38-git-send-email-zhang.zhanghailiang@huawei.com> <56C53B2C.6040902@redhat.com> From: Hailiang Zhang Message-ID: <56C53E99.9020102@huawei.com> Date: Thu, 18 Feb 2016 11:46:33 +0800 MIME-Version: 1.0 In-Reply-To: <56C53B2C.6040902@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: xiecl.fnst@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, armbru@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com, hongyang.yang@easystack.cn On 2016/2/18 11:31, Jason Wang wrote: > > > On 02/06/2016 05:28 PM, zhanghailiang wrote: >> Enable all buffer filters that added by COLO while >> go into COLO process, and disable them while exit COLO. >> >> Signed-off-by: zhanghailiang >> Cc: Jason Wang >> Cc: Yang Hongyang >> --- >> v14: >> - New patch >> --- >> migration/colo.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/migration/colo.c b/migration/colo.c >> index 235578b..86a7638 100644 >> --- a/migration/colo.c >> +++ b/migration/colo.c >> @@ -104,10 +104,26 @@ static void secondary_vm_do_failover(void) >> } >> } >> >> +static void colo_set_filter_status(NetFilterState *nf, void *opaque, >> + Error **errp) >> +{ >> + char colo_filter[128]; >> + char *name = object_get_canonical_path_component(OBJECT(nf)); >> + char *status = opaque; >> + >> + snprintf(colo_filter, sizeof(colo_filter), "%scolo", nf->netdev_id); >> + if (strcmp(colo_filter, name)) { >> + return; >> + } > > Checking by name is not elegant. As we've discussed last time, why not > let filter-buffer track all filters with zero interval in a linked list > and just export a helper to disable and enable them all? Things will be > greatly simplified with this, and there's even no need for patch 36. > > Yes, i know what you mean, but we have to add another 'QTAILQ_ENTRY() entry' like member into struct NetFilterState if we do like that, is it acceptable ? > . >