From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45605) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQPN-0004Mx-Gf for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:22:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWQPJ-0003AB-Cp for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:22:21 -0500 Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:38679) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQPJ-00039A-2F for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:22:17 -0500 Received: by mail-wm0-x230.google.com with SMTP id a4so30368516wme.1 for ; Thu, 18 Feb 2016 07:22:16 -0800 (PST) Sender: Paolo Bonzini References: <56BCCB44.4060203@redhat.com> <1455795518-19205-1-git-send-email-dimara@arrikto.com> From: Paolo Bonzini Message-ID: <56C5E1A5.2030001@redhat.com> Date: Thu, 18 Feb 2016 16:22:13 +0100 MIME-Version: 1.0 In-Reply-To: <1455795518-19205-1-git-send-email-dimara@arrikto.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] log: Redirect stderr to logfile if deamonized List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dimitris Aragiorgis , qemu-devel@nongnu.org On 18/02/2016 12:38, Dimitris Aragiorgis wrote: > In case of daemonize, use the logfile passed with the -D option in > order to redirect stderr to it instead of /dev/null. > > Also remove some unused code in log.h. > > Signed-off-by: Dimitris Aragiorgis > --- > include/qemu/log.h | 6 ------ > os-posix.c | 6 +++++- > util/log.c | 11 +++++++++-- > 3 files changed, 14 insertions(+), 9 deletions(-) > > diff --git a/include/qemu/log.h b/include/qemu/log.h > index 30817f7..dda65fd 100644 > --- a/include/qemu/log.h > +++ b/include/qemu/log.h > @@ -94,12 +94,6 @@ static inline void qemu_log_close(void) > } > } > > -/* Set up a new log file */ > -static inline void qemu_log_set_file(FILE *f) > -{ > - qemu_logfile = f; > -} > - > /* define log items */ > typedef struct QEMULogItem { > int mask; > diff --git a/os-posix.c b/os-posix.c > index cce62ed..92fa3ba 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -37,6 +37,7 @@ > #include "qemu-options.h" > #include "qemu/rcu.h" > #include "qemu/error-report.h" > +#include "qemu/log.h" > > #ifdef CONFIG_LINUX > #include > @@ -275,7 +276,10 @@ void os_setup_post(void) > > dup2(fd, 0); > dup2(fd, 1); > - dup2(fd, 2); > + /* In case -D is given do not redirect stderr to /dev/null */ > + if (!qemu_logfile) { > + dup2(fd, 2); > + } > > close(fd); > > diff --git a/util/log.c b/util/log.c > index 2709e98..a7ddc7e 100644 > --- a/util/log.c > +++ b/util/log.c > @@ -56,13 +56,20 @@ void do_qemu_set_log(int log_flags, bool use_own_buffers) > #ifdef CONFIG_TRACE_LOG > qemu_loglevel |= LOG_TRACE; > #endif > - if (qemu_loglevel && !qemu_logfile) { > + if ((qemu_loglevel || is_daemonized()) && !qemu_logfile) { > if (logfilename) { > qemu_logfile = fopen(logfilename, log_append ? "a" : "w"); > if (!qemu_logfile) { > perror(logfilename); > _exit(1); > } > + /* In case we are a daemon redirect stderr to logfile */ > + if (is_daemonized()) { > + dup2(fileno(qemu_logfile), STDERR_FILENO); > + fclose(qemu_logfile); > + /* This will skip closing logfile in qemu_log_close() */ > + qemu_logfile = stderr; > + } > } else { > /* Default to stderr if no log file specified */ > qemu_logfile = stderr; > @@ -82,7 +89,7 @@ void do_qemu_set_log(int log_flags, bool use_own_buffers) > log_append = 1; > } > } > - if (!qemu_loglevel && qemu_logfile) { > + if (!qemu_loglevel && !is_daemonized() && qemu_logfile) { > qemu_log_close(); > } Why is this necessary? Perhaps qemu_log_close should dup(1,2) if QEMU is daemonized. The rest looks great. Paolo