From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXmYS-0006FC-Tm for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:13:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXmYP-0005Ms-MT for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:13:20 -0500 Received: from mx2.parallels.com ([199.115.105.18]:36547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXmYP-0005KK-HH for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:13:17 -0500 References: <1455259174-3384-1-git-send-email-den@openvz.org> <20160218051702.GA4440@grmbl.mre> From: "Denis V. Lunev" Message-ID: <56CACE50.2040301@openvz.org> Date: Mon, 22 Feb 2016 12:01:04 +0300 MIME-Version: 1.0 In-Reply-To: <20160218051702.GA4440@grmbl.mre> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org, Juan Quintela On 02/18/2016 08:17 AM, Amit Shah wrote: > Can someone from the block team please give this a review? > > Thanks, guys? > On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: >> There is a possibility to hit an assert in qcow2_get_specific_info that >> s->qcow_version is undefined. This happens when VM in starting from >> suspended state, i.e. it processes incoming migration, and in the same >> time 'info block' is called. >> >> The problem is that qcow2_invalidate_cache() closes the image and >> memset()s BDRVQcowState in the middle. >> >> This operation should not be performed in coroutine context. >> >> Changes from v1: >> - fixed spelling. Eric, thank you for spell checking >> >> Signed-off-by: Denis V. Lunev >> CC: Paolo Bonzini >> CC: Juan Quintela >> CC: Amit Shah >> > Amit