From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY8Un-0005d6-LP for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:39:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY8Uk-0005T1-DF for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:39:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY8Uk-0005Su-5o for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:38:58 -0500 References: <1454750932-7556-1-git-send-email-zhang.zhanghailiang@huawei.com> <1454750932-7556-38-git-send-email-zhang.zhanghailiang@huawei.com> <56C53B2C.6040902@redhat.com> <56C53E99.9020102@huawei.com> <56C572FD.1070306@huawei.com> From: Jason Wang Message-ID: <56CC1A8C.3050500@redhat.com> Date: Tue, 23 Feb 2016 16:38:36 +0800 MIME-Version: 1.0 In-Reply-To: <56C572FD.1070306@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hailiang Zhang , qemu-devel@nongnu.org Cc: xiecl.fnst@cn.fujitsu.com, zhangchen.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, armbru@redhat.com, peter.huangpeng@huawei.com, arei.gonglei@huawei.com, stefanha@redhat.com, amit.shah@redhat.com, dgilbert@redhat.com, hongyang.yang@easystack.cn On 02/18/2016 03:30 PM, Hailiang Zhang wrote: > Hi Jason, > > On 2016/2/18 11:46, Hailiang Zhang wrote: >> On 2016/2/18 11:31, Jason Wang wrote: >>> >>> >>> On 02/06/2016 05:28 PM, zhanghailiang wrote: >>>> Enable all buffer filters that added by COLO while >>>> go into COLO process, and disable them while exit COLO. >>>> >>>> Signed-off-by: zhanghailiang >>>> Cc: Jason Wang >>>> Cc: Yang Hongyang >>>> --- >>>> v14: >>>> - New patch >>>> --- >>>> migration/colo.c | 32 ++++++++++++++++++++++++++++++++ >>>> 1 file changed, 32 insertions(+) >>>> >>>> diff --git a/migration/colo.c b/migration/colo.c >>>> index 235578b..86a7638 100644 >>>> --- a/migration/colo.c >>>> +++ b/migration/colo.c >>>> @@ -104,10 +104,26 @@ static void secondary_vm_do_failover(void) >>>> } >>>> } >>>> >>>> +static void colo_set_filter_status(NetFilterState *nf, void *opaque, >>>> + Error **errp) >>>> +{ >>>> + char colo_filter[128]; >>>> + char *name = object_get_canonical_path_component(OBJECT(nf)); >>>> + char *status = opaque; >>>> + >>>> + snprintf(colo_filter, sizeof(colo_filter), "%scolo", >>>> nf->netdev_id); >>>> + if (strcmp(colo_filter, name)) { >>>> + return; >>>> + } >>> >>> Checking by name is not elegant. As we've discussed last time, why not >>> let filter-buffer track all filters with zero interval in a linked list >>> and just export a helper to disable and enable them all? Things will be >>> greatly simplified with this, and there's even no need for patch 36. >>> >>> >> >> Yes, i know what you mean, but we have to add another >> 'QTAILQ_ENTRY() entry' like member into struct NetFilterState >> if we do like that, is it acceptable ? >> > > Sorry for the hasty reply, ;) > > We can use a list to store all the colo related buffer filters > without adding any member to struct NetFilterState. > > The codes will be like: > > struct COLOListNode{ > void *opaque; > QLIST_ENTRY(COLOListNode) node; > }; > static QLIST_HEAD(, COLOListNode) COLOBufferFilters = > QLIST_HEAD_INITIALIZER(COLOBufferFilters); > > void colo_add_buffer_filter() > { > struct COLOListNode *filternode; > ... > > filter = object_new_with_props(); > > filternode = g_new0(struct COLOListNode, 1); > filternode->opaque = NETFILTER(filter); > QLIST_INSERT_HEAD(&COLOBufferFilters, filternode, node); > } > > And we can track all the colo releated filters directly by > visiting the *COLOBufferFilters* list. > > Thanks, > Hailiang Also fine, but looks suboptimal to my proposal (use a list private to filter-buffer). > >>> . >>> >> > > >