From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: xiecl.fnst@cn.fujitsu.com, lizhijian@cn.fujitsu.com,
quintela@redhat.com, armbru@redhat.com, yunhong.jiang@intel.com,
eddie.dong@intel.com, peter.huangpeng@huawei.com,
dgilbert@redhat.com, arei.gonglei@huawei.com,
stefanha@redhat.com, amit.shah@redhat.com,
zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v14 32/40] net/filter: Introduce a helper to add a filter to the netdev
Date: Tue, 23 Feb 2016 19:50:57 +0800 [thread overview]
Message-ID: <56CC47A1.1070705@huawei.com> (raw)
In-Reply-To: <56CC44F6.2030503@huawei.com>
On 2016/2/23 19:39, Hailiang Zhang wrote:
> On 2016/2/23 16:36, Jason Wang wrote:
>>
>>
>> On 02/18/2016 11:30 AM, Hailiang Zhang wrote:
>>> On 2016/2/18 11:19, Jason Wang wrote:
>>>>
>>>>
>>>> On 02/06/2016 05:28 PM, zhanghailiang wrote:
>>>>> We add a new helper function netdev_add_filter(),
>>>>> this function can help adding a filter object to a netdev.
>>>>>
>>>>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>>>>> Cc: Jason Wang <jasowang@redhat.com>
>>>>> Cc: Yang Hongyang <hongyang.yang@easystack.cn>
>>>>> ---
>>>>> include/net/filter.h | 7 +++++++
>>>>> net/filter.c | 34 ++++++++++++++++++++++++++++++++++
>>>>> 2 files changed, 41 insertions(+)
>>>>>
>>>>> diff --git a/include/net/filter.h b/include/net/filter.h
>>>>> index af3c53c..0159080 100644
>>>>> --- a/include/net/filter.h
>>>>> +++ b/include/net/filter.h
>>>>> @@ -55,6 +55,7 @@ struct NetFilterState {
>>>>> char *netdev_id;
>>>>> NetClientState *netdev;
>>>>> NetFilterDirection direction;
>>>>> + bool is_default;
>>>>
>>>> I believe we've agreed that, we will remove this flag? And it seems that
>>>> it was not used by following patches.
>>>>
>>>
>>> Oops, i forgot to remove this useless codes. I will fix it in next
>>> version.
>>>
>>>>> bool enabled;
>>>>> QTAILQ_ENTRY(NetFilterState) next;
>>>>> };
>>>>> @@ -74,4 +75,10 @@ ssize_t
>>>>> qemu_netfilter_pass_to_next(NetClientState *sender,
>>>>> int iovcnt,
>>>>> void *opaque);
>>>>>
>>>>> +NetFilterState *netdev_add_filter(const char *netdev_id,
>>>>> + const char *filter_type,
>>>>> + const char *filter_id,
>>>>> + bool enabled,
>>>>> + Error **errp);
>>>>> +
>>>>> #endif /* QEMU_NET_FILTER_H */
>>>>> diff --git a/net/filter.c b/net/filter.c
>>>>> index 5551cf1..dbe9399 100644
>>>>> --- a/net/filter.c
>>>>> +++ b/net/filter.c
>>>>> @@ -177,6 +177,7 @@ static void netfilter_init(Object *obj)
>>>>> * for netfilter will be enabled.
>>>>> */
>>>>> nf->enabled = true;
>>>>> + nf->is_default = false;
>>>>>
>>>>> object_property_add_str(obj, "netdev",
>>>>> netfilter_get_netdev_id,
>>>>> netfilter_set_netdev_id,
>>>>> @@ -232,6 +233,39 @@ static void netfilter_complete(UserCreatable
>>>>> *uc, Error **errp)
>>>>> QTAILQ_INSERT_TAIL(&nf->netdev->filters, nf, next);
>>>>> }
>>>>>
>>>>> +NetFilterState *netdev_add_filter(const char *netdev_id,
>>>>> + const char *filter_type,
>>>>> + const char *filter_id,
>>>>> + bool enabled,
>>>>> + Error **errp)
>>>>> +{
>>>>> + NetClientState *nc = qemu_find_netdev(netdev_id);
>>>>> + Object *filter;
>>>>> + Error *local_err = NULL;
>>>>> +
>>>>> + /* FIXME: Not support multiple queues */
>>>>> + if (!nc || nc->queue_index > 1) {
>>>>> + return NULL;
>>>>> + }
>>>>> + /* Not support vhost-net */
>>>>> + if (get_vhost_net(nc)) {
>>>>> + return NULL;
>>>>> + }
>>>>
>>>> We will check those in netfilter_complete(), no?
>>>>
>>>
>>> Yes, I'd like to check this more early here.
>>>
>>> Thanks,
>>> hailiang
>>
>> But what's the advantages here?
>
> Nothing special, here we just want to keep silent while users startup qemu
> with vhost=on, Or there will be an annoying "Vhost is not supported",
> since here we try to add each netdev a default filter.
>
Hmm, i made some mistake, we can remove the check here,
we call object_new_with_props(), with argument errp = NULL, there
won't be any complaint about vhost.
I will remove it in next version, thanks.
> Thanks,
> Hailiang
>
next prev parent reply other threads:[~2016-02-23 11:51 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 9:28 [Qemu-devel] [PATCH COLO-Frame v14 00/40] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT) zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 01/40] configure: Add parameter for configure to enable/disable COLO support zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 02/40] migration: Introduce capability 'x-colo' to migration zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 03/40] COLO: migrate colo related info to secondary node zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 04/40] migration: Integrate COLO checkpoint process into migration zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 05/40] migration: Integrate COLO checkpoint process into loadvm zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 06/40] COLO/migration: Create a new communication path from destination to source zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 07/40] COLO: Implement colo checkpoint protocol zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 08/40] COLO: Add a new RunState RUN_STATE_COLO zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 09/40] QEMUSizedBuffer: Introduce two help functions for qsb zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 10/40] COLO: Save PVM state to secondary side when do checkpoint zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 11/40] COLO: Load PVM's dirty pages into SVM's RAM cache temporarily zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 12/40] ram/COLO: Record the dirty pages that SVM received zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 13/40] COLO: Load VMState into qsb before restore it zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 14/40] COLO: Flush PVM's cached RAM into SVM's memory zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 15/40] COLO: Add checkpoint-delay parameter for migrate-set-parameters zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 16/40] COLO: synchronize PVM's state to SVM periodically zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 17/40] COLO failover: Introduce a new command to trigger a failover zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 18/40] COLO failover: Introduce state to record failover process zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 19/40] COLO: Implement failover work for Primary VM zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 20/40] COLO: Implement failover work for Secondary VM zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 21/40] qmp event: Add COLO_EXIT event to notify users while exited from COLO zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 22/40] COLO failover: Shutdown related socket fd when do failover zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 23/40] COLO failover: Don't do failover during loading VM's state zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 24/40] COLO: Process shutdown command for VM in COLO state zhanghailiang
2016-02-12 15:09 ` Dr. David Alan Gilbert
2016-02-16 6:17 ` Hailiang Zhang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 25/40] COLO: Update the global runstate after going into colo state zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 26/40] savevm: Introduce two helper functions for save/find loadvm_handlers entry zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 27/40] migration/savevm: Add new helpers to process the different stages of loadvm zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 28/40] migration/savevm: Export two helper functions for savevm process zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 29/40] COLO: Separate the process of saving/loading ram and device state zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 30/40] COLO: Split qemu_savevm_state_begin out of checkpoint process zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 31/40] net/filter: Add a 'status' property for filter object zhanghailiang
2016-02-18 3:00 ` Jason Wang
2016-02-18 3:27 ` Hailiang Zhang
2016-02-23 8:34 ` Jason Wang
2016-02-23 9:37 ` Hailiang Zhang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 32/40] net/filter: Introduce a helper to add a filter to the netdev zhanghailiang
2016-02-18 3:19 ` Jason Wang
2016-02-18 3:30 ` Hailiang Zhang
2016-02-23 8:36 ` Jason Wang
2016-02-23 11:39 ` Hailiang Zhang
2016-02-23 11:50 ` Hailiang Zhang [this message]
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 33/40] filter-buffer: Accept zero interval zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 34/40] net: Add notifier/callback for netdev init zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 35/40] COLO/filter: add each netdev a buffer filter zhanghailiang
2016-02-18 3:23 ` Jason Wang
2016-02-18 4:07 ` Hailiang Zhang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 36/40] net/filter: Add a helper to traverse all the filters zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 37/40] COLO: enable buffer filters for PVM zhanghailiang
2016-02-18 3:31 ` Jason Wang
2016-02-18 3:46 ` Hailiang Zhang
2016-02-18 7:30 ` Hailiang Zhang
2016-02-23 8:38 ` Jason Wang
2016-02-23 9:10 ` Hailiang Zhang
2016-02-23 8:37 ` Jason Wang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 38/40] filter-buffer: make filter_buffer_flush() public zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 39/40] COLO: flush buffered packets in checkpoint process or exit COLO zhanghailiang
2016-02-06 9:28 ` [Qemu-devel] [PATCH COLO-Frame v14 40/40] COLO: Add block replication into colo process zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CC47A1.1070705@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=amit.shah@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eddie.dong@intel.com \
--cc=hongyang.yang@easystack.cn \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhangchen.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).