qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Yanan Wang <wangyanan55@huawei.com>, qemu-devel@nongnu.org
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	wanghaibin.wang@huawei.com,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()
Date: Tue, 19 Oct 2021 10:23:16 +0200	[thread overview]
Message-ID: <57481b57-13cf-ee9d-b9ef-205b9e3de610@vivier.eu> (raw)
In-Reply-To: <20211008075040.18028-1-wangyanan55@huawei.com>

Le 08/10/2021 à 09:50, Yanan Wang a écrit :
> The expected output string from cpu_slot_to_string() ought to be
> like "socket-id: *, die-id: *, core-id: *, thread-id: *", so add
> the missing ", " before "die-id". This affects the readability
> of the error message.
> 
> Fixes: 176d2cda0d ("i386/cpu: Consolidate die-id validity in smp context")
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
>  hw/core/machine.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index b8d95eec32..0a23ae3106 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -1157,6 +1157,9 @@ static char *cpu_slot_to_string(const CPUArchId *cpu)
>          g_string_append_printf(s, "socket-id: %"PRId64, cpu->props.socket_id);
>      }
>      if (cpu->props.has_die_id) {
> +        if (s->len) {
> +            g_string_append_printf(s, ", ");
> +        }
>          g_string_append_printf(s, "die-id: %"PRId64, cpu->props.die_id);
>      }
>      if (cpu->props.has_core_id) {
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>


  parent reply	other threads:[~2021-10-19  8:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  7:50 [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string() Yanan Wang
2021-10-19  7:55 ` wangyanan (Y)
2021-10-19  8:23 ` Laurent Vivier [this message]
2021-10-26 12:55   ` wangyanan (Y)
2021-10-26 13:08     ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57481b57-13cf-ee9d-b9ef-205b9e3de610@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).