From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: Lucien Murray-Pitts <lucienmp_antispam@yahoo.com>
Subject: Re: [PATCH] m68k: Fix regression causing Single-Step via GDB/RSP to not single step
Date: Wed, 15 Jan 2020 11:54:45 -1000 [thread overview]
Message-ID: <577e6e33-bb6f-5925-a106-304b678f3d49@linaro.org> (raw)
In-Reply-To: <20200115110359.1885149-1-laurent@vivier.eu>
On 1/15/20 1:03 AM, Laurent Vivier wrote:
> + if (dc->base.singlestep_enabled) {
> + tcg_gen_movi_i32(QREG_PC, dc->pc);
> + gen_helper_raise_exception(cpu_env, tcg_const_i32(EXCP_DEBUG));
This leaks the temporary, and so not quite ideal. It would be of more concern
if the rest of the m68k port was audited, so that you could turn on leak detection.
I would suggest routing all calls to gen_helper_raise_exception through a
function (gen_raise_exception, usually), which takes an int argument, and does
all of the TCGv_i32 management internally.
But otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-01-15 21:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:03 [PATCH] m68k: Fix regression causing Single-Step via GDB/RSP to not single step Laurent Vivier
2020-01-15 21:54 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577e6e33-bb6f-5925-a106-304b678f3d49@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=lucienmp_antispam@yahoo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).