From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB6DC433B4 for ; Wed, 14 Apr 2021 03:14:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EA54613BD for ; Wed, 14 Apr 2021 03:14:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA54613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWVzE-00032r-8J for qemu-devel@archiver.kernel.org; Tue, 13 Apr 2021 23:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWVyI-0002d0-5V for qemu-devel@nongnu.org; Tue, 13 Apr 2021 23:13:42 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:33486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWVyG-0005zS-Eb for qemu-devel@nongnu.org; Tue, 13 Apr 2021 23:13:41 -0400 Received: by mail-pf1-x42c.google.com with SMTP id a85so12347221pfa.0 for ; Tue, 13 Apr 2021 20:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UHqEgRmkG/wUkB8gH1KDikR5pfAqgCIrGztC2L+7fKc=; b=pHP5NrMnOka6Whk3sAt7na+Lb2wfqf8Ok0II+C9fOaAZqUmD2cNv77sksRMiHEhDyI f3AeYJG7Mt041oIcHllDbd+N4Fiv3q9HfiI6ra+MXx6CkTj9zkTuFJNU8kJNO5ddjXvj UCSbRuNxK1CS1qIj0TZ+2oPIu6JGtk6EX3airdEPeTC1Of1bdkcgl/QGtkSRA83zHFqA fV078GzxStahGTs0jpPPrf1zy0XDnxe7oOtYfKL/AaPieBOb/R5SjN9Mrap2kgfEk7Ou obB9mIosy0vqXNo9C9K4Blu8XEccipV58bnWJi12tRMae0J4GU0ou8FEGBgfjQ38J9cS Wi+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UHqEgRmkG/wUkB8gH1KDikR5pfAqgCIrGztC2L+7fKc=; b=WbYEgHSbNfOMrjtfB194X3F+t/JMQeE2zEuUjE9+9Slw4RnAm94Wb7vfqEQzdujbsw 41Jo0fJgUqt7MyLpRyBmdeWBehQ6gZYI7y0bjstCJSBTJXL8H5CHt/tQC+FWsSmz48xz rqEIcAYtY3cCSyke+AhRBBVn7/by0J7WrEywK5gXE1PsKlz4Id42fOAnmGPGbFRUs8/+ U0kYunq4QbEvDMa2nJ96ftJ6pYdxrUpzevo5YBuPIaGfIHvil8oeGFX5t/BGlmVTVRXh EABlkhIKdYknmMnmcECkCExQNKtPiX/r1lpTiP/gFOG+QuwdDOjJEmYBRQLhYNXUOsqS +Y0Q== X-Gm-Message-State: AOAM5336Jvaa88ddm/OG4DkjdD0LYguhSsvBUegmYxYzOAoFu0IwNPxM kQzbpUSkPFEssLZN1BVs03jQbA== X-Google-Smtp-Source: ABdhPJyxLGvxnjRCtmQOdauVE/rsEADkyTC5MGzDxQj0woH6EcdYaWzGViPyDGAMJIuz2Jv8mqsKSg== X-Received: by 2002:a63:fe12:: with SMTP id p18mr35638247pgh.425.1618370018881; Tue, 13 Apr 2021 20:13:38 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id b7sm15872997pgs.62.2021.04.13.20.13.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Apr 2021 20:13:38 -0700 (PDT) Subject: Re: [PATCH v2 4/9] target/riscv: Remove the hardcoded MSTATUS_SD macro To: Alistair Francis , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <2d6d0483c1a1e7aedd1c410b34812ea8e076cb33.1618356725.git.alistair.francis@wdc.com> From: Richard Henderson Message-ID: <5948b55e-a769-59f2-8ef5-0b0e33dcb4b0@linaro.org> Date: Tue, 13 Apr 2021 20:13:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <2d6d0483c1a1e7aedd1c410b34812ea8e076cb33.1618356725.git.alistair.francis@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair23@gmail.com, bmeng.cn@gmail.com, palmer@dabbelt.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/13/21 4:33 PM, Alistair Francis wrote: > +#ifndef CONFIG_USER_ONLY > +# ifdef TARGET_RISCV32 > +# define is_32bit(ctx) true > +# else > +static inline bool is_32bit(DisasContext *ctx) > +{ > + return !(ctx->misa & RV64); > +} > +# endif > +#endif It's going to be soon enough when this is used by user-only too. I'd structure this as #ifdef TARGET_RISCV32 # define is_32bit(ctx) true #elif defined(CONFIG_USER_ONLY) # define is_32bit(ctx) false #else static inline... #endif > tmp = tcg_temp_new(); > + sd = is_32bit(ctx) ? MSTATUS32_SD : MSTATUS64_SD; > + > + > tcg_gen_ld_tl(tmp, cpu_env, offsetof(CPURISCVState, mstatus)); Careful with the extra whitespace. Reviewed-by: Richard Henderson r~