From: John Snow <jsnow@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: pkrempa@redhat.com, berrange@redhat.com, kchamart@redhat.com,
libvir-list@redhat.com, wencongyang2@huawei.com,
xiechanglong.d@gmail.com, qemu-devel@nongnu.org,
armbru@redhat.com, yur@virtuozzo.com,
nshirokovskiy@virtuozzo.com, den@openvz.org, dim@virtuozzo.com
Subject: Re: [PATCH v2 1/3] docs/block-replication: use blockdev-backup
Date: Fri, 14 May 2021 16:23:43 -0400 [thread overview]
Message-ID: <5b11ec16-e0a5-e208-5446-dde794df1d28@redhat.com> (raw)
In-Reply-To: <20210505135803.67896-2-vsementsov@virtuozzo.com>
On 5/5/21 9:58 AM, Vladimir Sementsov-Ogievskiy wrote:
> We are going to deprecate drive-backup, so don't mention it here.
> Moreover, blockdev-backup seems more correct in the context.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> docs/block-replication.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/block-replication.txt b/docs/block-replication.txt
> index 108e9166a8..59eb2b33b3 100644
> --- a/docs/block-replication.txt
> +++ b/docs/block-replication.txt
> @@ -79,7 +79,7 @@ Primary | || Secondary disk <--------- hidden-disk 5 <---------
> || | |
> || | |
> || '-------------------------'
> - || drive-backup sync=none 6
> + || blockdev-backup sync=none 6
>
> 1) The disk on the primary is represented by a block device with two
> children, providing replication between a primary disk and the host that
> @@ -101,7 +101,7 @@ should support bdrv_make_empty() and backing file.
> that is modified by the primary VM. It should also start as an empty disk,
> and the driver supports bdrv_make_empty() and backing file.
>
> -6) The drive-backup job (sync=none) is run to allow hidden-disk to buffer
> +6) The blockdev-backup job (sync=none) is run to allow hidden-disk to buffer
> any state that would otherwise be lost by the speculative write-through
> of the NBD server into the secondary disk. So before block replication,
> the primary disk and secondary disk should contain the same data.
>
next prev parent reply other threads:[~2021-05-14 20:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 13:58 [PATCH v2 0/3] qapi & doc: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-05-05 13:58 ` [PATCH v2 1/3] docs/block-replication: use blockdev-backup Vladimir Sementsov-Ogievskiy
2021-05-14 20:23 ` John Snow [this message]
2021-05-05 13:58 ` [PATCH v2 2/3] docs/interop/bitmaps: " Vladimir Sementsov-Ogievskiy
2021-05-06 9:34 ` Kashyap Chamarthy
2021-05-14 20:27 ` John Snow
2021-05-05 13:58 ` [PATCH v2 3/3] qapi: deprecate drive-backup Vladimir Sementsov-Ogievskiy
2021-05-06 9:57 ` Kashyap Chamarthy
2021-05-14 22:38 ` John Snow
2021-05-24 14:06 ` Vladimir Sementsov-Ogievskiy
2021-05-24 18:37 ` John Snow
2021-09-01 13:29 ` Vladimir Sementsov-Ogievskiy
2021-09-01 14:33 ` Markus Armbruster
2021-06-08 11:12 ` Markus Armbruster
2021-06-08 11:46 ` Vladimir Sementsov-Ogievskiy
2021-06-09 10:49 ` Markus Armbruster
2021-07-05 19:12 ` Vladimir Sementsov-Ogievskiy
2021-09-15 19:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b11ec16-e0a5-e208-5446-dde794df1d28@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=den@openvz.org \
--cc=dim@virtuozzo.com \
--cc=kchamart@redhat.com \
--cc=libvir-list@redhat.com \
--cc=nshirokovskiy@virtuozzo.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
--cc=yur@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).