From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A827C3A589 for ; Mon, 19 Aug 2019 02:05:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 301832184D for ; Mon, 19 Aug 2019 02:05:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ESdKcZUe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 301832184D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzX3O-0000IT-2m for qemu-devel@archiver.kernel.org; Sun, 18 Aug 2019 22:05:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40793) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzX2k-0008FD-C9 for qemu-devel@nongnu.org; Sun, 18 Aug 2019 22:05:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzX2j-0007lW-C5 for qemu-devel@nongnu.org; Sun, 18 Aug 2019 22:05:10 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:36310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzX2j-0007kx-6f for qemu-devel@nongnu.org; Sun, 18 Aug 2019 22:05:09 -0400 Received: by mail-wm1-x341.google.com with SMTP id g67so194800wme.1 for ; Sun, 18 Aug 2019 19:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=g6dI5BdvtjU8z17AF96KyQ0SDFufQXz6orPeilT5Ke4=; b=ESdKcZUeVjJC7B6N8RR3CqNN9eSGSAMO4gigvYVt+8eZVwTQFeuqw3PDNwIliR3ReP IElhS7xwi81Fr14mXOVmwGPRl2TjwcWvRr4lRCWfxPdGTs36XvTKrXEPFYHu+D7d5EMA 8PEcZo76MB9ETbFitEJDbJZlHXHYq4spGWqRrXuBOOe0736+W9R2Ap9FcURmj41Bd46K PFzeP6FipbGsmCBfZVz+Eu32+OTJhNGVjyUEbDuGICFMAdGGVSlcnnZ7I3yse8sl53rK OPs9K4FfZw/WEqDGZADlI6Ok8XMlZa674ugukm7BzlDOAlvmFduBMT6IZwhioYslbXyP pKog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=g6dI5BdvtjU8z17AF96KyQ0SDFufQXz6orPeilT5Ke4=; b=i2rOH62QAWBMhorFWTxYJICWyWrvnFKYSpuxo1B2BwrHjaX/bdbjNSiw06xnIyVcBW PUrCRQAyTAE8lmFH+azcvMuyuPb0/MKyACUzP/zmvHx9gI8+OFbNoQ5lJiHxC5K50kDX A8OT7uybm9jll3vEFut+lJOTSWohdE1y91k5oY5nJD+LplWM1ighBBuw5eSrMyEh1bpz 9J9GQuJVPaCFzqdzsAZPLNPRrw8fnNForM0hgytNoDDWcIr1nPzmUQQtjKjLaoq1AsfB zy8BOkYH+D8CWaDWR2KID5AZxJhj9KVP0CiuQ0M5YW1gC4wSlAC645M50DotLmkH/CRs 1rzQ== X-Gm-Message-State: APjAAAVQxMI4OQKEStzDmXfPKSfsnGOPLIkfgArc9Kewz/2ERtd1Lmw5 COJim/EGYOmB524e5Og3GK0= X-Google-Smtp-Source: APXvYqywJstmfXXm+8PEQagRnihyLCTWjvOhxtFbp12qRbgXy1NHG1VIDM4artu26i+DDDOMJaNNdw== X-Received: by 2002:a1c:7c06:: with SMTP id x6mr17824965wmc.133.1566180307644; Sun, 18 Aug 2019 19:05:07 -0700 (PDT) Received: from ?IPv6:fd00:835b:d940:d4fc:1::d3? (2a01-036c-0113-49c9-0001-0000-0000-00d3.pool6.digikabel.hu. [2a01:36c:113:49c9:1::d3]) by smtp.gmail.com with ESMTPSA id 4sm25762745wro.78.2019.08.18.19.05.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Aug 2019 19:05:06 -0700 (PDT) From: "=?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?=" X-Google-Original-From: =?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <4db4fa19-65f5-0bc8-3354-a1779bbdb0f3@redhat.com> Message-ID: <5b788626-f2bd-68a2-5825-2ad5b96ff221@gmail.com> Date: Mon, 19 Aug 2019 04:05:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4db4fa19-65f5-0bc8-3354-a1779bbdb0f3@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 Subject: Re: [Qemu-devel] [PATCH v4 14/14] audio: fix memory leak reported by ASAN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 2019-08-19 01:25, Philippe Mathieu-Daudé wrote: > Hi Zoltán, > > On 8/19/19 1:06 AM, Kővágó, Zoltán wrote: >> Signed-off-by: Kővágó, Zoltán >> --- >> audio/audio.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/audio/audio.c b/audio/audio.c >> index 924dddf2e7..9b28abca14 100644 >> --- a/audio/audio.c >> +++ b/audio/audio.c >> @@ -1343,6 +1343,12 @@ static void free_audio_state(AudioState *s) >> qapi_free_Audiodev(s->dev); >> s->dev = NULL; >> } >> + >> + if (s->ts) { >> + timer_free(s->ts); >> + s->ts = NULL; >> + } > > Why not directly fix audio_cleanup() previous to your series? I didn't really think about it. When I found the memory leak and figured out it wasn't made by one of my patches, I just patched it on top of my worktree. > >> + >> g_free(s); >> } >> >> Regards, Zoltan