From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F33C4361B for ; Thu, 17 Dec 2020 23:35:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 767CA23441 for ; Thu, 17 Dec 2020 23:35:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 767CA23441 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq2oK-0007jJ-46 for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 18:35:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq2nL-0007FX-Pf for qemu-devel@nongnu.org; Thu, 17 Dec 2020 18:34:55 -0500 Received: from mx2.suse.de ([195.135.220.15]:40294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq2nJ-0002uT-0E for qemu-devel@nongnu.org; Thu, 17 Dec 2020 18:34:51 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 81B01ACE0; Thu, 17 Dec 2020 23:34:47 +0000 (UTC) Subject: Re: [PULL 07/17] i386: move hyperv_vendor_id initialization to x86_cpu_realizefn() To: Eduardo Habkost References: <20201217184620.3945917-1-ehabkost@redhat.com> <20201217184620.3945917-8-ehabkost@redhat.com> <20201217225313.GO3140057@habkost.net> From: Claudio Fontana Message-ID: <5deb513d-336f-fadb-a15f-75f51e2211ed@suse.de> Date: Fri, 18 Dec 2020 00:34:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201217225313.GO3140057@habkost.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-devel@nongnu.org, Paolo Bonzini , Vitaly Kuznetsov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/17/20 11:53 PM, Eduardo Habkost wrote: > On Thu, Dec 17, 2020 at 11:33:57PM +0100, Claudio Fontana wrote: >> Hello all, >> >> On 12/17/20 7:46 PM, Eduardo Habkost wrote: >>> From: Vitaly Kuznetsov >>> >>> As a preparation to expanding Hyper-V CPU features early, move >>> hyperv_vendor_id initialization to x86_cpu_realizefn(). Introduce >>> x86_cpu_hyperv_realize() to not not pollute x86_cpu_realizefn() >>> itself. >> >> this seems to fit very well the ongoing work on separating accelerator specific realize functions; >> >> related to the previous discussions about the class hierarchies, >> do you think that we should have a separate class in target/i386/kvm/ for a hyperv variant of the kvm-cpu.c? >> >> Should it be a separate class or a subclass of "kvm-accel-x86_64-cpu" ? > > I don't see how a separate QOM class for Hyper-V would be helpful > here. What would be the problem you are trying to solve in this > case? there is now a call to accelerator specific code x86_hyperv_cpu_realize just before cpu_exec_realize, tying the generic target/i386/cpu.c code to kvm/hyperv-specific accel initialization. if this is just a feature of the kvm accel, maybe I should just move all to kvm-cpu.c and that's it. Thanks, Claudio > > Note that the Hyper-V features here are just a set of > configurable VCPU features that appear on CPUID. This is not a > different kind of hypervisor and/or a different kind of > accelerator. >