From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, "Volker Rümelin" <vr_qemu@t-online.de>
Subject: Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
Date: Tue, 25 May 2021 09:48:22 +0200 [thread overview]
Message-ID: <5ee136e9-3d4b-058d-fcc4-cb56023ee230@amsat.org> (raw)
In-Reply-To: <20210513171244.3940519-1-f4bug@amsat.org>
ping? (patch reviewed)
On 5/13/21 7:12 PM, Philippe Mathieu-Daudé wrote:
> Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/ps2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index 72cdb80ae1c..02d7e5da723 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s)
> void ps2_queue(PS2State *s, int b)
> {
> ps2_queue_noirq(s, b);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_2(PS2State *s, int b1, int b2)
> @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2)
>
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> ps2_queue_noirq(s, b4);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> /* keycode is the untranslated scancode in the current scancode set. */
>
prev parent reply other threads:[~2021-05-25 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 17:12 [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Philippe Mathieu-Daudé
2021-05-13 18:23 ` Volker Rümelin
2021-05-17 1:56 ` Bin Meng
2021-05-25 7:48 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ee136e9-3d4b-058d-fcc4-cb56023ee230@amsat.org \
--to=f4bug@amsat.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).