From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFCDC433E0 for ; Wed, 17 Mar 2021 19:25:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A28164E42 for ; Wed, 17 Mar 2021 19:25:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A28164E42 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMbnb-0002UH-GL for qemu-devel@archiver.kernel.org; Wed, 17 Mar 2021 15:25:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMbmB-000156-AU; Wed, 17 Mar 2021 15:24:15 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:58320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMbm8-0004u4-OO; Wed, 17 Mar 2021 15:24:14 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 9D09B7462E1; Wed, 17 Mar 2021 20:24:07 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 2BF9D7462D6; Wed, 17 Mar 2021 20:24:07 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 2AA957462DB; Wed, 17 Mar 2021 20:24:07 +0100 (CET) Date: Wed, 17 Mar 2021 20:24:07 +0100 (CET) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it In-Reply-To: <67bc4257-7b46-628c-6e46-916eff4206be@amsat.org> Message-ID: <5f1ac469-9f5a-525c-2d2-8bd5a6198cc@eik.bme.hu> References: <67bc4257-7b46-628c-6e46-916eff4206be@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-1212553515-1616009047=:70007" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Gibson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-1212553515-1616009047=:70007 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote: > On 3/17/21 2:17 AM, BALATON Zoltan wrote: >> To allow reusing ISA bridge emulation for vt8231_isa move the device >> state of vt82c686b_isa emulation in an abstract via_isa class. This >> change breaks migration back compatibility but this is not an issue >> for Fuloong2E machine which is not versioned or migration supported. >> >> Signed-off-by: BALATON Zoltan >> --- >> hw/isa/vt82c686.c | 70 ++++++++++++++++++++++------------------ >> include/hw/pci/pci_ids.h | 2 +- >> 2 files changed, 40 insertions(+), 32 deletions(-) > > Now than "hw/usb: Extract VT82C686 UHCI PCI function into a new unit" > is merged as commit 6f2bcd5fc84, this is acceptable IMHO, so: > Reviewed-by: Philippe Mathieu-Daudé Still don't see what does the USB function do with this that does not have any reference to USB but thanks. Will you send a pull requests with the series? Regards, BALATON Zoltan --3866299591-1212553515-1616009047=:70007--