From: Akihiko Odaki <akihiko.odaki@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private
Date: Mon, 28 Jun 2021 12:56:33 +0900 [thread overview]
Message-ID: <60171e96-dbee-1510-0d09-13ec64b7229f@gmail.com> (raw)
In-Reply-To: <20210617121830.2776182-1-philmd@redhat.com>
Hi,
qemu-nbd.c still refers to members of QCryptoTLSCreds* and can't be
compiled.
Regards,
Akihiko Odaki
On 2021/06/17 21:18, Philippe Mathieu-Daudé wrote:
> Missing review: 5 & 6
>
> Follow Daniel suggestion to simplify qcrypto TLS implementations,
> aiming to solve the OSX build failure.
>
> Since v4:
> - Do not introduce qcrypto_tls_session_check_role (Richard, Daniel)
> - Added R-b tags
>
> Since v3:
> - Added missing @errp docstring description
>
> Since v2:
> - Add Error* argument (Daniel)
> - Move structure definitions to "tlscredspriv.h"
>
> Philippe Mathieu-Daudé (6):
> crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper
> block/nbd: Use qcrypto_tls_creds_check_endpoint()
> chardev/socket: Use qcrypto_tls_creds_check_endpoint()
> migration/tls: Use qcrypto_tls_creds_check_endpoint()
> ui/vnc: Use qcrypto_tls_creds_check_endpoint()
> crypto: Make QCryptoTLSCreds* structures private
>
> crypto/tlscredspriv.h | 45 ++++++++++++++++++++++++++++++
> include/crypto/tls-cipher-suites.h | 6 ----
> include/crypto/tlscreds.h | 30 ++++++++++----------
> include/crypto/tlscredsanon.h | 12 --------
> include/crypto/tlscredspsk.h | 12 --------
> include/crypto/tlscredsx509.h | 10 -------
> block/nbd.c | 6 ++--
> blockdev-nbd.c | 6 ++--
> chardev/char-socket.c | 18 ++++--------
> crypto/tls-cipher-suites.c | 7 +++++
> crypto/tlscreds.c | 12 ++++++++
> crypto/tlscredsanon.c | 2 ++
> crypto/tlscredspsk.c | 2 ++
> crypto/tlscredsx509.c | 1 +
> crypto/tlssession.c | 1 +
> migration/tls.c | 6 +---
> ui/vnc.c | 7 +++--
> 17 files changed, 101 insertions(+), 82 deletions(-)
>
next prev parent reply other threads:[~2021-06-28 3:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 12:18 [PATCH v5 0/6] crypto: Make QCryptoTLSCreds* structures private Philippe Mathieu-Daudé
2021-06-17 12:18 ` [PATCH v5 1/6] crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper Philippe Mathieu-Daudé
2021-06-17 12:18 ` [PATCH v5 2/6] block/nbd: Use qcrypto_tls_creds_check_endpoint() Philippe Mathieu-Daudé
2021-06-17 12:18 ` [PATCH v5 3/6] chardev/socket: " Philippe Mathieu-Daudé
2021-06-17 12:18 ` [PATCH v5 4/6] migration/tls: " Philippe Mathieu-Daudé
2021-06-17 12:18 ` [PATCH v5 5/6] ui/vnc: " Philippe Mathieu-Daudé
2021-06-17 15:34 ` Richard Henderson
2021-06-18 8:35 ` Daniel P. Berrangé
2021-06-17 12:18 ` [PATCH v5 6/6] crypto: Make QCryptoTLSCreds* structures private Philippe Mathieu-Daudé
2021-06-18 8:35 ` Daniel P. Berrangé
2021-06-28 3:56 ` Akihiko Odaki [this message]
2021-06-28 13:22 ` [PATCH v5 0/6] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60171e96-dbee-1510-0d09-13ec64b7229f@gmail.com \
--to=akihiko.odaki@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).