From: Paolo Bonzini <pbonzini@redhat.com>
To: Yury Kotov <yury-kotov@yandex-team.ru>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Richard Henderson <rth@twiddle.net>,
Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Weil <sw@weilnetz.de>
Cc: "open list:Overall" <qemu-devel@nongnu.org>,
"yc-core@yandex-team.ru" <yc-core@yandex-team.ru>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct
Date: Mon, 19 Aug 2019 19:11:40 +0200 [thread overview]
Message-ID: <6193fef9-244a-fbd7-5506-160d841145fa@redhat.com> (raw)
In-Reply-To: <82eb0ad0-d4ee-bfc8-0087-d8910f6cf504@redhat.com>
On 19/08/19 18:39, Paolo Bonzini wrote:
> On 15/08/19 11:13, Yury Kotov wrote:
>> Ping ping
>
> Hi,
>
> sorry for the delay, I was waiting for the 4.1 release.
>
> I would like to make a small change so that preemption of QEMU does not
> result in overly long sleeps. The following patch on top of yours computes
> the throttle-end time just once. Of course you can still be unlucky if
> you are preempted at the wrong time, but the window becomes much smaller.
The new unit test is hanging for me on aarch64-softmmu.
Paolo
> diff --git a/cpus.c b/cpus.c
> index d091dbd..d7e2145 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -781,7 +781,7 @@ static void cpu_throttle_thread(CPUState *cpu, run_on_cpu_data opaque)
> {
> double pct;
> double throttle_ratio;
> - int64_t sleeptime_ns;
> + int64_t sleeptime_ns, end;
>
> if (!cpu_throttle_get_percentage()) {
> return;
> @@ -792,18 +792,17 @@ static void cpu_throttle_thread(CPUState *cpu, run_on_cpu_data opaque)
> /* Add 1ns to fix double's rounding error (like 0.9999999...) */
> sleeptime_ns = (int64_t)(throttle_ratio * CPU_THROTTLE_TIMESLICE_NS + 1);
>
> - while (sleeptime_ns >= SCALE_MS && !cpu->stop) {
> - int64_t start, end;
> - start = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
> - qemu_cond_timedwait(cpu->halt_cond, &qemu_global_mutex,
> - sleeptime_ns / SCALE_MS);
> - end = qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
> - sleeptime_ns -= end - start;
> - }
> - if (sleeptime_ns >= SCALE_US && !cpu->stop) {
> - qemu_mutex_unlock_iothread();
> - g_usleep(sleeptime_ns / SCALE_US);
> - qemu_mutex_lock_iothread();
> + end = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + sleeptime_ns;
> + while (sleeptime_ns > 0 && !cpu->stop) {
> + if (sleeptime_ns > SCALE_MS) {
> + qemu_cond_timedwait(cpu->halt_cond, &qemu_global_mutex,
> + sleeptime_ns / SCALE_MS);
> + } else {
> + qemu_mutex_unlock_iothread();
> + g_usleep(sleeptime_ns / SCALE_US);
> + qemu_mutex_lock_iothread();
> + }
> + sleeptime_ns = end - qemu_clock_get_ns(QEMU_CLOCK_REALTIME);
> }
> atomic_set(&cpu->throttle_thread_scheduled, 0);
> }
>
next prev parent reply other threads:[~2019-08-19 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 13:42 [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct Yury Kotov
2019-07-23 13:42 ` [Qemu-devel] [PATCH v4 1/3] qemu-thread: Add qemu_cond_timedwait Yury Kotov
2019-07-23 13:42 ` [Qemu-devel] [PATCH v4 2/3] cpus: Fix throttling during vm_stop Yury Kotov
2019-07-23 13:42 ` [Qemu-devel] [PATCH v4 3/3] tests/migration: Add a test for auto converge Yury Kotov
2019-07-23 17:34 ` Dr. David Alan Gilbert
2019-07-23 17:34 ` Dr. David Alan Gilbert
2019-08-07 7:42 ` [Qemu-devel] [PATCH v4 0/3] High downtime with 95+ throttle pct Yury Kotov
2019-08-15 9:13 ` Yury Kotov
2019-08-19 16:39 ` Paolo Bonzini
2019-08-19 17:11 ` Paolo Bonzini [this message]
2019-08-23 8:27 ` Yury Kotov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6193fef9-244a-fbd7-5506-160d841145fa@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=yc-core@yandex-team.ru \
--cc=yury-kotov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).