From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 3/3] docs/devel/qtest: Include libqtest API reference
Date: Tue, 6 Oct 2020 19:12:17 +0200 [thread overview]
Message-ID: <62336b4c-79b7-287b-8d9d-c269ce213c61@redhat.com> (raw)
In-Reply-To: <20201005205228.697463-4-ehabkost@redhat.com>
On 05/10/2020 22.52, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> docs/devel/qtest.rst | 6 ++++++
> tests/qtest/libqos/libqtest.h | 20 ++++++++++----------
> 2 files changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/docs/devel/qtest.rst b/docs/devel/qtest.rst
> index 3bf9ebee7f0..075fe5f7d53 100644
> --- a/docs/devel/qtest.rst
> +++ b/docs/devel/qtest.rst
> @@ -64,3 +64,9 @@ QTest Protocol
>
> .. kernel-doc:: softmmu/qtest.c
> :doc: QTest Protocol
> +
> +
> +libqtest API reference
> +----------------------
> +
> +.. kernel-doc:: tests/qtest/libqos/libqtest.h
> diff --git a/tests/qtest/libqos/libqtest.h b/tests/qtest/libqos/libqtest.h
> index a6ee1654f20..209fcf69737 100644
> --- a/tests/qtest/libqos/libqtest.h
> +++ b/tests/qtest/libqos/libqtest.h
> @@ -24,7 +24,7 @@ typedef struct QTestState QTestState;
>
> /**
> * qtest_initf:
> - * @fmt...: Format for creating other arguments to pass to QEMU, formatted
> + * @fmt: Format for creating other arguments to pass to QEMU, formatted
> * like sprintf().
> *
> * Convenience wrapper around qtest_init().
> @@ -87,7 +87,7 @@ void qtest_quit(QTestState *s);
> * @s: #QTestState instance to operate on.
> * @fds: array of file descriptors
> * @fds_num: number of elements in @fds
> - * @fmt...: QMP message to send to qemu, formatted like
> + * @fmt: QMP message to send to qemu, formatted like
> * qobject_from_jsonf_nofail(). See parse_escape() for what's
> * supported after '%'.
> *
> @@ -100,7 +100,7 @@ QDict *qtest_qmp_fds(QTestState *s, int *fds, size_t fds_num,
> /**
> * qtest_qmp:
> * @s: #QTestState instance to operate on.
> - * @fmt...: QMP message to send to qemu, formatted like
> + * @fmt: QMP message to send to qemu, formatted like
I think you should mention those changes to all those "fmt..." in the commit
message?
Thomas
next prev parent reply other threads:[~2020-10-06 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:52 [PATCH 0/3] docs: Include QTest protocol and libqtest API on documentation Eduardo Habkost
2020-10-05 20:52 ` [PATCH 1/3] docs: Move QTest documentation to its own document Eduardo Habkost
2020-10-05 20:52 ` [PATCH 2/3] docs/devel/qtest: Include protocol spec in document Eduardo Habkost
2020-10-07 11:03 ` Paolo Bonzini
2020-10-07 11:39 ` Eduardo Habkost
2020-10-07 12:01 ` Paolo Bonzini
2020-10-05 20:52 ` [PATCH 3/3] docs/devel/qtest: Include libqtest API reference Eduardo Habkost
2020-10-06 17:12 ` Thomas Huth [this message]
2020-10-06 17:22 ` Eduardo Habkost
2020-10-06 12:42 ` [PATCH 0/3] docs: Include QTest protocol and libqtest API on documentation Paolo Bonzini
2020-10-06 17:12 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62336b4c-79b7-287b-8d9d-c269ce213c61@redhat.com \
--to=thuth@redhat.com \
--cc=ehabkost@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).