From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55346C43331 for ; Sat, 28 Mar 2020 15:49:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28AD2206F6 for ; Sat, 28 Mar 2020 15:49:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28AD2206F6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-sky.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIDhj-0004gD-Bq for qemu-devel@archiver.kernel.org; Sat, 28 Mar 2020 11:48:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42040) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIDgw-0003oR-Jm for qemu-devel@nongnu.org; Sat, 28 Mar 2020 11:48:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIDgu-0006US-J7 for qemu-devel@nongnu.org; Sat, 28 Mar 2020 11:48:10 -0400 Received: from smtp2200-217.mail.aliyun.com ([121.197.200.217]:37105) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jIDgu-0006Ep-28; Sat, 28 Mar 2020 11:48:08 -0400 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.4277855|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_system_inform|0.0154129-9.47399e-05-0.984492; FP=0|0|0|0|0|-1|-1|-1; HT=e01a16370; MF=zhiwei_liu@c-sky.com; NM=1; PH=DS; RN=9; RT=9; SR=0; TI=SMTPD_---.H6jJXbl_1585410477; Received: from 192.168.3.18(mailfrom:zhiwei_liu@c-sky.com fp:SMTPD_---.H6jJXbl_1585410477) by smtp.aliyun-inc.com(10.147.41.199); Sat, 28 Mar 2020 23:47:58 +0800 Subject: Re: [PATCH v6 41/61] target/riscv: vector floating-point merge instructions To: Richard Henderson , alistair23@gmail.com, chihmin.chao@sifive.com, palmer@dabbelt.com References: <20200317150653.9008-1-zhiwei_liu@c-sky.com> <20200317150653.9008-42-zhiwei_liu@c-sky.com> From: LIU Zhiwei Message-ID: <623a1ba2-04f0-7e63-dfbd-ff02ed0acc9d@c-sky.com> Date: Sat, 28 Mar 2020 23:47:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 121.197.200.217 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guoren@linux.alibaba.com, wenmeng_zhang@c-sky.com, qemu-riscv@nongnu.org, qemu-devel@nongnu.org, wxy194768@alibaba-inc.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/3/28 11:23, Richard Henderson wrote: > On 3/17/20 8:06 AM, LIU Zhiwei wrote: >> + for (i = 0; i < vl; i++) { \ >> + if (!vm && !vext_elem_mask(v0, mlen, i)) { \ >> + ETYPE s2 = *((ETYPE *)vs2 + H(i)); \ >> + *((ETYPE *)vd + H1(i)) = s2; \ > H1 should be H. Yes. > >> + } else { \ >> + *((ETYPE *)vd + H(i)) = (ETYPE)s1; \ >> + } \ > You can also hoist the s2 dereference out of the IF, and let the assignment be > unconditional. > > *((ETYPE *)vd + H(i)) > = (!vm && !vext_elem_mask(v0, mlen, i) ? s2 : s1); Yes, it's much better. Zhiwei > > > r~