From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] audio: Add missing fall through comments
Date: Fri, 19 Jul 2019 09:29:57 +0200 [thread overview]
Message-ID: <6241fd95-789f-f560-2170-0544cded1720@redhat.com> (raw)
In-Reply-To: <20190718193441.12490-1-sw@weilnetz.de>
On 7/18/19 9:34 PM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> audio/audio.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/audio/audio.c b/audio/audio.c
> index 5fd9a58a80..a7a13e900a 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -304,6 +304,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
>
> case AUDIO_FORMAT_S16:
> sign = 1;
> + /* fall through */
> case AUDIO_FORMAT_U16:
> bits = 16;
> shift = 1;
> @@ -311,6 +312,7 @@ void audio_pcm_init_info (struct audio_pcm_info *info, struct audsettings *as)
>
> case AUDIO_FORMAT_S32:
> sign = 1;
> + /* fall through */
> case AUDIO_FORMAT_U32:
> bits = 32;
> shift = 2;
>
next prev parent reply other threads:[~2019-07-19 7:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 19:34 [Qemu-devel] [PATCH] audio: Add missing fall through comments Stefan Weil
2019-07-19 6:11 ` Marc-André Lureau
2019-07-19 7:29 ` Philippe Mathieu-Daudé [this message]
2019-07-19 7:43 ` Aleksandar Markovic
2019-07-19 10:21 ` Philippe Mathieu-Daudé
2019-08-13 10:20 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6241fd95-789f-f560-2170-0544cded1720@redhat.com \
--to=philmd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).