From: Eric Blake <eblake@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>,
alex.williamson@redhat.com, cjia@nvidia.com
Cc: cohuck@redhat.com, aik@ozlabs.ru, Zhengxiao.zx@Alibaba-inc.com,
shuangtai.tst@alibaba-inc.com, qemu-devel@nongnu.org,
peterx@redhat.com, eauger@redhat.com, yi.l.liu@intel.com,
quintela@redhat.com, ziye.yang@intel.com, armbru@redhat.com,
mlevitsk@redhat.com, pasic@linux.ibm.com, felipe@nutanix.com,
zhi.a.wang@intel.com, kevin.tian@intel.com, yan.y.zhao@intel.com,
dgilbert@redhat.com, changpeng.liu@intel.com,
eskultet@redhat.com, Ken.Xue@amd.com,
jonathan.davies@nutanix.com, pbonzini@redhat.com
Subject: Re: [PATCH v18 QEMU 18/18] qapi: Add VFIO devices migration stats in Migration stats
Date: Tue, 5 May 2020 09:13:29 -0500 [thread overview]
Message-ID: <630eb2d9-ed8c-3b10-cee4-a1a907f8b00c@redhat.com> (raw)
In-Reply-To: <1588632293-18932-19-git-send-email-kwankhede@nvidia.com>
On 5/4/20 5:44 PM, Kirti Wankhede wrote:
> Added amount of bytes transferred to the target VM by all VFIO devices
>
> Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> ---
Reviewing just the UI:
> +++ b/qapi/migration.json
> @@ -144,6 +144,18 @@
> 'active', 'postcopy-active', 'postcopy-paused',
> 'postcopy-recover', 'completed', 'failed', 'colo',
> 'pre-switchover', 'device', 'wait-unplug' ] }
> +##
> +# @VfioStats:
> +#
> +# Detailed VFIO devices migration statistics
> +#
> +# @bytes: amount of bytes transferred to the target VM by VFIO devices
> +#
> +# Since: 5.0
s/5.0/5.1/
> +#
> +##
> +{ 'struct': 'VfioStats',
> + 'data': {'bytes': 'int' } }
>
> ##
> # @MigrationInfo:
> @@ -205,6 +217,10 @@
> #
> # @socket-address: Only used for tcp, to know what the real port is (Since 4.0)
> #
> +# @vfio: @VfioStats containing detailed VFIO devices migration statistics,
> +# only returned if VFIO device is present, migration is supported by all
> +# VFIO devices and status is 'active' or 'completed' (since 5.0)
here too
> +#
> # Since: 0.14.0
> ##
> { 'struct': 'MigrationInfo',
> @@ -220,7 +236,8 @@
> '*postcopy-blocktime' : 'uint32',
> '*postcopy-vcpu-blocktime': ['uint32'],
> '*compression': 'CompressionStats',
> - '*socket-address': ['SocketAddress'] } }
> + '*socket-address': ['SocketAddress'],
> + '*vfio': 'VfioStats' } }
>
> ##
> # @query-migrate:
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-05-05 14:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 22:44 [PATCH v18 QEMU 00/18] Add migration support for VFIO devices Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 01/18] vfio: KABI for migration interface - Kernel header placeholder Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 02/18] vfio: Add function to unmap VFIO region Kirti Wankhede
2020-05-05 6:16 ` Philippe Mathieu-Daudé
2020-05-06 19:23 ` Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 03/18] vfio: Add vfio_get_object callback to VFIODeviceOps Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 04/18] vfio: Add save and load functions for VFIO PCI devices Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 05/18] vfio: Add migration region initialization and finalize function Kirti Wankhede
2020-05-05 9:42 ` Cornelia Huck
2020-05-04 22:44 ` [PATCH v18 QEMU 06/18] vfio: Add VM state change handler to know state of VM Kirti Wankhede
2020-05-05 10:11 ` Cornelia Huck
2020-05-04 22:44 ` [PATCH v18 QEMU 07/18] vfio: Add migration state change notifier Kirti Wankhede
2020-05-05 10:46 ` Cornelia Huck
2020-05-04 22:44 ` [PATCH v18 QEMU 08/18] vfio: Register SaveVMHandlers for VFIO device Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 09/18] vfio: Add save state functions to SaveVMHandlers Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 10/18] vfio: Add load " Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 11/18] iommu: add callback to get address limit IOMMU supports Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 12/18] memory: Set DIRTY_MEMORY_MIGRATION when IOMMU is enabled Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 13/18] vfio: Add function to start and stop dirty pages tracking Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 14/18] vfio: Add vfio_listener_log_sync to mark dirty pages Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 15/18] vfio: Get migration capability flags for container Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 16/18] vfio: Add ioctl to get dirty pages bitmap during dma unmap Kirti Wankhede
2020-05-06 10:31 ` Cornelia Huck
2020-05-04 22:44 ` [PATCH v18 QEMU 17/18] vfio: Make vfio-pci device migration capable Kirti Wankhede
2020-05-04 22:44 ` [PATCH v18 QEMU 18/18] qapi: Add VFIO devices migration stats in Migration stats Kirti Wankhede
2020-05-05 14:13 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=630eb2d9-ed8c-3b10-cee4-a1a907f8b00c@redhat.com \
--to=eblake@redhat.com \
--cc=Ken.Xue@amd.com \
--cc=Zhengxiao.zx@Alibaba-inc.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=changpeng.liu@intel.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eauger@redhat.com \
--cc=eskultet@redhat.com \
--cc=felipe@nutanix.com \
--cc=jonathan.davies@nutanix.com \
--cc=kevin.tian@intel.com \
--cc=kwankhede@nvidia.com \
--cc=mlevitsk@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shuangtai.tst@alibaba-inc.com \
--cc=yan.y.zhao@intel.com \
--cc=yi.l.liu@intel.com \
--cc=zhi.a.wang@intel.com \
--cc=ziye.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).