* hw/net/rocker: Dubious code in tx_consume()
@ 2020-02-15 13:15 Philippe Mathieu-Daudé
2020-02-16 6:59 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-02-15 13:15 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Jason Wang, qemu-devel, Stefan Hajnoczi
Hi Jiri,
I am trying to understand this code Scott Feldman added in commit
dc488f88806:
157 static int tx_consume(Rocker *r, DescInfo *info)
158 {
...
212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
213 tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
214 }
...
252 if (iovcnt) {
253 /* XXX perform Tx offloads */
254 /* XXX silence compiler for now */
255 tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
256 }
Nobody complained TSO_MSS is not implemented during almost 5 years.
Can we remove this code?
Thanks,
Phil.
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: hw/net/rocker: Dubious code in tx_consume()
2020-02-15 13:15 hw/net/rocker: Dubious code in tx_consume() Philippe Mathieu-Daudé
@ 2020-02-16 6:59 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2020-02-16 6:59 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: Jason Wang, qemu-devel, Stefan Hajnoczi
Sat, Feb 15, 2020 at 02:15:22PM CET, philmd@redhat.com wrote:
>Hi Jiri,
>
>I am trying to understand this code Scott Feldman added in commit
>dc488f88806:
>
> 157 static int tx_consume(Rocker *r, DescInfo *info)
> 158 {
> ...
> 212 if (tlvs[ROCKER_TLV_TX_TSO_MSS]) {
> 213 tx_tso_mss = rocker_tlv_get_le16(tlvs[ROCKER_TLV_TX_TSO_MSS]);
> 214 }
> ...
> 252 if (iovcnt) {
> 253 /* XXX perform Tx offloads */
> 254 /* XXX silence compiler for now */
> 255 tx_l3_csum_off += tx_tso_mss = tx_tso_hdr_len = 0;
> 256 }
>
>Nobody complained TSO_MSS is not implemented during almost 5 years.
>Can we remove this code?
Yes, you can.
>
>Thanks,
>
>Phil.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-16 7:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-15 13:15 hw/net/rocker: Dubious code in tx_consume() Philippe Mathieu-Daudé
2020-02-16 6:59 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).