From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17AEC3A5A2 for ; Fri, 23 Aug 2019 17:06:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ACB152339D for ; Fri, 23 Aug 2019 17:06:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A8rqsPmB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACB152339D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1D0n-0007Mi-Q9 for qemu-devel@archiver.kernel.org; Fri, 23 Aug 2019 13:06:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54968) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1CzW-0006Pa-6d for qemu-devel@nongnu.org; Fri, 23 Aug 2019 13:04:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1CzV-0000Fh-0z for qemu-devel@nongnu.org; Fri, 23 Aug 2019 13:04:46 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:44751) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1CzU-0000Dn-QU for qemu-devel@nongnu.org; Fri, 23 Aug 2019 13:04:44 -0400 Received: by mail-pf1-x444.google.com with SMTP id c81so6817134pfc.11 for ; Fri, 23 Aug 2019 10:04:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FQ87yz3Iy6Wzj8Jj/rRfRc/tCoi10QfnBZxnhnK64u8=; b=A8rqsPmBk5r50JnRSG1enIlR5JGM6MuG7QzOKPY9q5w0BgGCpbaYv3kULnLKdMU3Z0 GL34miKn500W47JlstHqRb7FVYzmAqlXq0ZE2tsBL7DdHzoB3FKVIdHlmJoJJ/IeNIod Zt36ZY3clpLYLksAJVDbO6afKGbTM8DobZGpbuRGiLM0S1VBUpcThJInQdXkuoZMwasA ONvnatncl8H2ATL6TdhGWngCgDaK78yfhVHo/iMS7YXEFRj1ym0yJZUz43qBivM1auFj 34yuJN7ooVfDu/rhQIJPk5AYvJGeqFL5397sJ4Z6BEngR/PfmV8Iv2Xdibc7SQO/i2mW BdgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FQ87yz3Iy6Wzj8Jj/rRfRc/tCoi10QfnBZxnhnK64u8=; b=VE7smZEU7GZ3W7vUMWolKD+zXz32Aqy6XCUwb2oAR9nGoGl+oP7pvaJ1NmFIjy1vga d39GByEaLAqYBpiWUJQxkY5mcDtKdEz+WiMffdBNy2zdE+q4HsVOdC6wu4cjJIhx50Mz E9dJUbA7vz6GLkii8xWVbXz3Dat1VU9upEkHOqmLDkg5M2In+h4LZXd6LNIM+48FqCUb Q3T+Lvm99JVQZcKM/7a0p+4aXtqfhF48tRKTiRKK4aHf2xpVlFj1eiMhiSJp8e29PKD/ evGJL7oEM0OFhAxzuoH1gbWrUbPFvybkz1lOGBbPJ6wbG8qYCsd3W+jG0WthIw6UZKB1 HAig== X-Gm-Message-State: APjAAAUM7JvTvDL/mA+H+DbnPjRF1dQBGrjhGaN/gBCKdDiCyriTpd2H P+nwU2bEz/vlHOZYHRSuETdBGw== X-Google-Smtp-Source: APXvYqxqCO5U4r/HBSwFhUI3V4YKB7cPXhm5KcPmFcopILV6kaYa+2imQknioPm/4Do4dwUttTWhVw== X-Received: by 2002:a17:90b:f13:: with SMTP id br19mr6267254pjb.124.1566579881656; Fri, 23 Aug 2019 10:04:41 -0700 (PDT) Received: from [192.168.1.11] (97-113-7-119.tukw.qwest.net. [97.113.7.119]) by smtp.gmail.com with ESMTPSA id 131sm2575198pge.37.2019.08.23.10.04.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Aug 2019 10:04:40 -0700 (PDT) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20190823135811.13883-1-philmd@redhat.com> <20190823135811.13883-2-philmd@redhat.com> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <64061664-f79f-b074-8fec-fea24594d5df@linaro.org> Date: Fri, 23 Aug 2019 10:04:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190823135811.13883-2-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: Re: [Qemu-devel] [PATCH 1/4] target/arm: Restrict pre-ARMv7 cpus to TCG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Thomas Huth , qemu-arm@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/23/19 6:58 AM, Philippe Mathieu-Daudé wrote: > @@ -2535,6 +2544,7 @@ static const ARMCPUInfo arm_cpus[] = { > { .name = "arm1176", .initfn = arm1176_initfn }, > { .name = "arm11mpcore", .initfn = arm11mpcore_initfn }, > { .name = "cortex-m0", .initfn = cortex_m0_initfn, > +#endif > .class_init = arm_v7m_class_init }, > { .name = "cortex-m3", .initfn = cortex_m3_initfn, > .class_init = arm_v7m_class_init }, Ifdef is misplaced. This shouldn't even compile without CONFIG_TCG. Also, m-profile shouldn't work with kvm either, so I think the endif should go below cortex-m33. r~