From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFCA8C433C1 for ; Sun, 28 Mar 2021 16:51:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B69761966 for ; Sun, 28 Mar 2021 16:51:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B69761966 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQYd0-0000Aq-CW for qemu-devel@archiver.kernel.org; Sun, 28 Mar 2021 12:51:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQYad-0007tW-6Z for qemu-devel@nongnu.org; Sun, 28 Mar 2021 12:48:39 -0400 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:39684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQYaX-0000bF-IA for qemu-devel@nongnu.org; Sun, 28 Mar 2021 12:48:38 -0400 Received: by mail-oi1-x234.google.com with SMTP id i81so10914760oif.6 for ; Sun, 28 Mar 2021 09:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bpvXBfuCRjDDUniW3Dfns3wjb6vAkNtqNTUB4xXwzUw=; b=BkThfnQOn69QY9wx/mNA4zATe84O4DVGDmTHC93WduhJ9kEnYdY4u0dBlxnX/WGANU eLR33//b90S2uBmdHeG1zrS4DmtQSqKTh/LgoHumlRV6gcdDkHPkpb5jI0hluw+fUPEN GDOLLOeom+GQQ+kkUhrcqRVEto2YsRJBzvoxxROgligIGslkCVu1GVW20uXd5cyEaPrF H/48fha/q3EYmRGlrA0QkKrxaTB10jIBChAkSvjA+nMmsuBvP5jXnuUkKdTZtXzNtqya gOjjOm8LcRJBiYGJMQkN1KBYX73dMX+25ryU+fcF5yYbg4vRwdDTuH0lTXEyko8nmP3T 1Emg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bpvXBfuCRjDDUniW3Dfns3wjb6vAkNtqNTUB4xXwzUw=; b=rpa+tQGSnWUfVL2yscwgViHERU7wctZpWLEY63etCkUHPJqBKpPubey3u5D5ySZOCc XFCt/dX3BSM7WNXVdqkGFnBpqwyfSwiZWzhnD4c08VGb5xrKc/oOcy5NByKd53CZdoYF ZUd6Lov5cY/VOKENcjFQNI4riykRW9uKrtiGenTbDyrPu8hv8cPCd+4y7ydVdIAkDV3U gG6NtcHv/Gsx/DHMTB0GXZe9vAJBp4bLfGfCVfPRvnJBOJXZuGeB6ZohPgf/o3dYjnbd sCAxYsPhHse1HyzICh5H0Aj5Ax/KqR72RjAz7C7QF7yDhzZBCNS+kAWG6CXOp3VNsvIj VHHg== X-Gm-Message-State: AOAM530ZtonwA+1vBxlpjnmHIJMCJFV5FuJNSZ51nI7bm107lBxTgXAi W55iwaGcHCyX5NCjqzUcxn/mHw== X-Google-Smtp-Source: ABdhPJz/RQtEpqPNziAfd6MVE4wRMBqhxTLvCEsngrpSfAlGX5KGoCT0TaP1g66rRciH6JCReRit3Q== X-Received: by 2002:a05:6808:993:: with SMTP id a19mr15706271oic.73.1616950112280; Sun, 28 Mar 2021 09:48:32 -0700 (PDT) Received: from [192.168.211.34] (171.189-204-159.bestelclientes.com.mx. [189.204.159.171]) by smtp.gmail.com with ESMTPSA id z199sm2315032ooa.39.2021.03.28.09.48.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Mar 2021 09:48:31 -0700 (PDT) Subject: Re: [RFC v12 32/65] target/arm: move TCGCPUOps to tcg/tcg-cpu.c To: Claudio Fontana , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210326193701.5981-1-cfontana@suse.de> <20210326193701.5981-33-cfontana@suse.de> From: Richard Henderson Message-ID: <6529fb48-cfcb-5fc8-2001-fa0c8cef9d35@linaro.org> Date: Sun, 28 Mar 2021 10:48:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210326193701.5981-33-cfontana@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/26/21 1:36 PM, Claudio Fontana wrote: > move the TCGCPUOps interface to tcg/tcg-cpu.c > in preparation for the addition of the TCG accel-cpu class. > > Signed-off-by: Claudio Fontana > --- > target/arm/cpu.h | 1 - > target/arm/internals.h | 5 - > target/arm/tcg/tcg-cpu.h | 6 + > target/arm/cpu-sysemu.c | 4 + > target/arm/cpu.c | 209 +-------------------------------- > target/arm/cpu_tcg.c | 2 +- > target/arm/tcg/helper.c | 1 + > target/arm/tcg/tcg-cpu.c | 229 +++++++++++++++++++++++++++++++++++++ > target/arm/tcg/meson.build | 1 + > 9 files changed, 244 insertions(+), 214 deletions(-) > create mode 100644 target/arm/tcg/tcg-cpu.c I'm confused about the differing placement of arm_tcg_ops and arm_v7m_tcg_ops. It seems like one or the other is a mistake. r~