From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26572C2D0CE for ; Tue, 21 Jan 2020 11:44:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E63E220882 for ; Tue, 21 Jan 2020 11:44:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GHfQR6Nd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E63E220882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itrxQ-00068R-4B for qemu-devel@archiver.kernel.org; Tue, 21 Jan 2020 06:44:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46494) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itrwm-0005bL-6Z for qemu-devel@nongnu.org; Tue, 21 Jan 2020 06:43:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itrwl-0007KV-65 for qemu-devel@nongnu.org; Tue, 21 Jan 2020 06:43:52 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:32655 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1itrwl-0007KM-3H for qemu-devel@nongnu.org; Tue, 21 Jan 2020 06:43:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579607030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=kUlAlkFfXTXA/zdAQQoTSG1yAqpKXPnVQtg8Nj79fAE=; b=GHfQR6NdlM6+CCcVrNeCatxI/ignBKPDMJmNBaQ38LKd+iG/0+IfaxHZ4TPUAPu5KXww/e AfNYK1ZGrXG70gvLo6gShY1cXWYrkFbW2F3E2Cod3HP34fLA5qSs5u20prI49n7sWWLeuI PGaMH5fPAl7d96GoQMGXoyhLyskONAs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-1gWNSLgaO7W1lqY-UWsGww-1; Tue, 21 Jan 2020 06:43:47 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 212E1190B2A0; Tue, 21 Jan 2020 11:43:46 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-121.ams2.redhat.com [10.36.116.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B27745C3FD; Tue, 21 Jan 2020 11:43:43 +0000 (UTC) Subject: Re: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , mrezanin@redhat.com, qemu-devel@nongnu.org References: <07957dcab31f65de3dd30efa91e6b9152ac79879.1579598240.git.mrezanin@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <6696e7be-6db3-0fe8-d7b4-39c1bace8d38@redhat.com> Date: Tue, 21 Jan 2020 12:43:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 1gWNSLgaO7W1lqY-UWsGww-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , peter.maydell@linaro.org, qemu-trivial@nongnu.org, Joel Stanley Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 21/01/2020 11.44, C=C3=A9dric Le Goater wrote: > On 1/21/20 11:02 AM, Thomas Huth wrote: >> On 21/01/2020 10.28, mrezanin@redhat.com wrote: >>> From: Miroslav Rezanina >>> >>> Compiler reports uninitialized warning for cmd_flags variable. >>> >>> Adding NULL initialization to prevent this warning. >>> >>> Signed-off-by: Miroslav Rezanina >>> --- >>> hw/i2c/aspeed_i2c.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c >>> index 2da04a4..445182a 100644 >>> --- a/hw/i2c/aspeed_i2c.c >>> +++ b/hw/i2c/aspeed_i2c.c >>> @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus= ) >>> =20 >>> static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus) >>> { >>> - g_autofree char *cmd_flags; >>> + g_autofree char *cmd_flags =3D NULL; >>> uint32_t count; >>> =20 >>> if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) { >> >> Reviewed-by: Thomas Huth >> >> ... maybe someone with enough Perl-foo (i.e. not me ;-)) should add a >> check to our check_patch.pl script so that it complains when new code is >> introduced that uses g_autofree without initializing the variable... >=20 > weird. The cmd_flags variable is assigned just after and used > in a trace.=20 I don't know, but my guess is that you could compile with tracing disabled - in that case gcc might maybe optimize the assignment away, too... ? Thomas