From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: wainersm@redhat.com, "Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org, "Willian Rampazzo" <willianr@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Warner Losh" <imp@bsdimp.com>
Subject: Re: [PATCH] tests/vm/freebsd: Increase code coverage
Date: Sat, 6 Nov 2021 15:30:43 +0100 [thread overview]
Message-ID: <66978f50-1064-4832-e080-f0f4a964e324@amsat.org> (raw)
In-Reply-To: <d4ee4cf1-26e9-7344-f29f-ed242464e9dc@redhat.com>
On 6/15/21 19:40, Wainer dos Santos Moschetta wrote:
> Hi,
>
> On 6/15/21 2:19 PM, Daniel P. Berrangé wrote:
>> On Tue, Jun 15, 2021 at 06:02:02PM +0100, Daniel P. Berrangé wrote:
>>> On Mon, May 31, 2021 at 05:53:25PM -0300, Wainer dos Santos Moschetta
>>> wrote:
>>>> Hi,
>>>>
>>>> On 5/31/21 7:03 AM, Philippe Mathieu-Daudé wrote:
>>>>> Install more dependencies to increase code coverage.
>>>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>>> ---
>>>>> tests/vm/freebsd | 5 +++++
>>>>> 1 file changed, 5 insertions(+)
>>>> With or without this patch I got an error when `make
>>>> vm-build-freebsd`. It
>>>> fails to install packages.
>>>>
>>>> For example, with this patch I got:
>>>>
>>>> < Output omitted>
>>>>
>>>> ### Installing packages ...
>>>> Failed to prepare guest environment
>>>> Traceback (most recent call last):
>>>> File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 634, in main
>>>> return vm.build_image(args.image)
>>>> File "/home/wmoschet/src/qemu/tests/vm/freebsd", line 206, in
>>>> build_image
>>>> self.ssh_root_check("pkg install -y %s\n" % " ".join(self.pkgs))
>>>> File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 255, in
>>>> ssh_root_check
>>>> self._ssh_do(self._config["root_user"], cmd, True)
>>>> File "/home/wmoschet/src/qemu/tests/vm/basevm.py", line 242, in
>>>> _ssh_do
>>>> raise Exception("SSH command failed: %s" % cmd)
>>>> Exception: SSH command failed: pkg install -y git pkgconf bzip2
>>>> python37
>>>> ninja bash gmake gsed gettext cyrus-sasl gnutls nettle jpeg-turbo
>>>> png sdl2
>>>> gtk3 libxkbcommon pixman libepoxy mesa-libs zstd usbredir
>>>>
>>>> Is it a known issue?
>>> Hard to actually tell what the error really is. This message is
>>> only giving the command that was invoked, but seems to have thrown
>>> away stdout/stderr which would have the messages telling us what
>>> went wrong. This lack of error reporting in basevm.py so badly
>>> needs to be fixed, otherwise we're working blind when debugging
>>> failures.
>> Hmm, when I try the same command, it *does* print all the output
>> so you can see what's going on, but it doesn't actually fail for
>> me either (without this patch).
>
> Thomas sent me a message in private while ago that the error could be
> related with the amount of ssh keys in my agent-ssh. I didn' t check
> that hypothesis yet; will debug a littler further and let you all posted.
>
> ah, if this problem cannot be reproduced on other machines....I see no
> reason to hold this patch.
OK thank you!
prev parent reply other threads:[~2021-11-06 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 10:03 [PATCH] tests/vm/freebsd: Increase code coverage Philippe Mathieu-Daudé
2021-05-31 20:53 ` Wainer dos Santos Moschetta
2021-06-15 16:55 ` Philippe Mathieu-Daudé
2021-06-15 20:09 ` Warner Losh
2021-06-15 20:51 ` Warner Losh
2021-06-15 17:02 ` Daniel P. Berrangé
2021-06-15 17:19 ` Daniel P. Berrangé
2021-06-15 17:40 ` Wainer dos Santos Moschetta
2021-11-06 14:30 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66978f50-1064-4832-e080-f0f4a964e324@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=imp@bsdimp.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).