From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F02C41604 for ; Tue, 6 Oct 2020 17:42:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68EA12075A for ; Tue, 6 Oct 2020 17:42:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68EA12075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPqzH-0002JM-G6 for qemu-devel@archiver.kernel.org; Tue, 06 Oct 2020 13:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPqxy-0001Id-LW; Tue, 06 Oct 2020 13:41:34 -0400 Received: from smtpout1.mo529.mail-out.ovh.net ([178.32.125.2]:50009) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPqxw-000054-0m; Tue, 06 Oct 2020 13:41:34 -0400 Received: from mxplan5.mail.ovh.net (unknown [10.108.20.195]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id BF27C62AF608; Tue, 6 Oct 2020 19:41:29 +0200 (CEST) Received: from kaod.org (37.59.142.105) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Tue, 6 Oct 2020 19:41:29 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-105G006c50df8bd-90c5-41e0-8d5b-fe6b1de2db55, 2331A23DC679A54E7C1604B88AF6A34BAE14B46D) smtp.auth=clg@kaod.org Subject: Re: [PATCH v2 5/6] spapr/xive: Activate StoreEOI at the source level To: Greg Kurz References: <20201005165147.526426-1-clg@kaod.org> <20201005165147.526426-6-clg@kaod.org> <20201006190645.33a05694@bahia.lan> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <66bb5bdf-fe88-33a8-85ea-dde8aa78379e@kaod.org> Date: Tue, 6 Oct 2020 19:41:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201006190645.33a05694@bahia.lan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.105] X-ClientProxiedBy: DAG8EX1.mxp5.local (172.16.2.71) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 98547d32-1a78-4b58-9492-35b8ba7d9753 X-Ovh-Tracer-Id: 12414453850723355555 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdduudegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfhisehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecuggftrfgrthhtvghrnhepjeekudeuudevleegudeugeekleffveeludejteffiedvledvgfekueefudehheefnecukfhppedtrddtrddtrddtpdefjedrheelrddugedvrddutdehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehgrhhouhhgsehkrghougdrohhrgh Received-SPF: pass client-ip=178.32.125.2; envelope-from=clg@kaod.org; helo=smtpout1.mo529.mail-out.ovh.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/06 12:58:29 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gustavo Romero , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/6/20 7:06 PM, Greg Kurz wrote: > On Mon, 5 Oct 2020 18:51:46 +0200 > Cédric Le Goater wrote: > >> When the StoreEOI capability is "on", the H_INT_GET_SOURCE_INFO will >> set the StoreEOI flag for all sources. This could be an issue if >> StoreEOI is not supported on a specific source, of a passthrough >> device for instance. In that case, we could either introduce a new KVM >> ioctl to query the characteristics of the source at the HW level or >> deactivate StoreEOI on the machine. >> >> This is theoretically unsafe on a POWER9 host but it still runs. >> > > Patch looks good but as said before, what is the likeliness of something > really painful to happen on a POWER9 host ? Nothing will happen because POWER9 systems deactivate StoreEOI. You need a custom skiboot to add it back. C. >> Signed-off-by: Cédric Le Goater >> --- >> hw/intc/spapr_xive.c | 1 + >> hw/ppc/spapr_irq.c | 6 ++++++ >> 2 files changed, 7 insertions(+) >> >> diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c >> index 1fa09f287ac0..41f2719ff93a 100644 >> --- a/hw/intc/spapr_xive.c >> +++ b/hw/intc/spapr_xive.c >> @@ -280,6 +280,7 @@ static void spapr_xive_instance_init(Object *obj) >> SpaprXive *xive = SPAPR_XIVE(obj); >> >> object_initialize_child(obj, "source", &xive->source, TYPE_XIVE_SOURCE); >> + object_property_add_alias(obj, "flags", OBJECT(&xive->source), "flags"); >> >> object_initialize_child(obj, "end_source", &xive->end_source, >> TYPE_XIVE_END_SOURCE); >> diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c >> index f59960339ec3..cdf9f9df4173 100644 >> --- a/hw/ppc/spapr_irq.c >> +++ b/hw/ppc/spapr_irq.c >> @@ -325,9 +325,14 @@ void spapr_irq_init(SpaprMachineState *spapr, Error **errp) >> >> if (spapr->irq->xive) { >> uint32_t nr_servers = spapr_max_server_number(spapr); >> + uint64_t flags = 0; >> DeviceState *dev; >> int i; >> >> + if (spapr_get_cap(spapr, SPAPR_CAP_STOREEOI) == SPAPR_CAP_ON) { >> + flags |= XIVE_SRC_STORE_EOI; >> + } >> + >> dev = qdev_new(TYPE_SPAPR_XIVE); >> qdev_prop_set_uint32(dev, "nr-irqs", smc->nr_xirqs + SPAPR_XIRQ_BASE); >> /* >> @@ -337,6 +342,7 @@ void spapr_irq_init(SpaprMachineState *spapr, Error **errp) >> qdev_prop_set_uint32(dev, "nr-ends", nr_servers << 3); >> object_property_set_link(OBJECT(dev), "xive-fabric", OBJECT(spapr), >> &error_abort); >> + object_property_set_int(OBJECT(dev), "flags", flags, &error_abort); >> sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); >> >> spapr->xive = SPAPR_XIVE(dev); >