From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org,
Philippe Mathieu-Daude <philmd@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/input: Do not enable CONFIG_PCKBD by default
Date: Wed, 15 Jan 2020 12:46:18 +0100 [thread overview]
Message-ID: <670ab2be-d6ba-1eef-fd56-e6f8df7e0085@vivier.eu> (raw)
In-Reply-To: <20200115113748.24757-1-thuth@redhat.com>
Le 15/01/2020 à 12:37, Thomas Huth a écrit :
> The i8042 device is part of the chipset of a machine, so it should
> be selected by the machines or chipsets (e.g. SuperIO chipsets),
> and not be enabled by default.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/input/Kconfig | 1 -
> hw/isa/Kconfig | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/input/Kconfig b/hw/input/Kconfig
> index 287f08887b..a2f25725be 100644
> --- a/hw/input/Kconfig
> +++ b/hw/input/Kconfig
> @@ -7,7 +7,6 @@ config LM832X
>
> config PCKBD
> bool
> - default y
> select PS2
> depends on ISA_BUS
>
> diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig
> index 8a38813cc1..c7f07854f7 100644
> --- a/hw/isa/Kconfig
> +++ b/hw/isa/Kconfig
> @@ -16,6 +16,7 @@ config I82378
> config ISA_SUPERIO
> bool
> select ISA_BUS
> + select PCKBD
>
> config PC87312
> bool
>
It is also used by R4K but the Kconfig already includes it, so:
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-01-15 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 11:37 [PATCH] hw/input: Do not enable CONFIG_PCKBD by default Thomas Huth
2020-01-15 11:46 ` Laurent Vivier [this message]
2020-01-15 14:45 ` Philippe Mathieu-Daudé
2020-01-15 13:10 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=670ab2be-d6ba-1eef-fd56-e6f8df7e0085@vivier.eu \
--to=laurent@vivier.eu \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).