From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-ppc@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include
Date: Mon, 12 Aug 2019 13:47:36 +0200 [thread overview]
Message-ID: <67d69f94-1606-dec9-cefa-349952407888@redhat.com> (raw)
In-Reply-To: <20190812113739.16587-2-philmd@redhat.com>
On 8/12/19 1:37 PM, Philippe Mathieu-Daudé wrote:
> The "cpu.h" include makes devices target-specific. Since it
> is not used, remove it, so the device become generic (we can
> now compile it once for all targets).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/sm501.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 5918f59b2b..b15fb1ab00 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -28,7 +28,6 @@
> #include "qapi/error.h"
> #include "qemu/log.h"
> #include "qemu/module.h"
> -#include "cpu.h"
> #include "hw/hw.h"
> #include "hw/char/serial.h"
> #include "ui/console.h"
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2019-08-12 11:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 11:37 [Qemu-devel] [PATCH 0/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:37 ` [Qemu-devel] [PATCH 1/2] hw/display/sm501: Remove unused include Philippe Mathieu-Daudé
2019-08-12 11:47 ` Thomas Huth [this message]
2019-08-21 9:07 ` Laurent Vivier
2019-08-12 11:37 ` [Qemu-devel] [PATCH 2/2] hw/display: Compile various display devices as common object Philippe Mathieu-Daudé
2019-08-12 11:51 ` Thomas Huth
2019-08-21 9:00 ` Gerd Hoffmann
2019-08-21 10:31 ` Philippe Mathieu-Daudé
2019-08-21 10:47 ` Laurent Vivier
2019-08-21 11:13 ` Gerd Hoffmann
2019-08-12 11:56 ` [Qemu-devel] [PATCH 0/2] " BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67d69f94-1606-dec9-cefa-349952407888@redhat.com \
--to=thuth@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).