From: Max Reitz <mreitz@redhat.com>
To: Sam Eiderman <shmuel.eiderman@oracle.com>,
kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: arbel.moshe@oracle.com, liran.alon@oracle.com,
eyal.moscovici@oracle.com, karl.heubaum@oracle.com
Subject: Re: [Qemu-devel] [PATCH v2 2/3] vmdk: Reduce the max bound for L1 table size
Date: Wed, 19 Jun 2019 19:09:49 +0200 [thread overview]
Message-ID: <6851ef37-29d0-f74a-32a5-1840a5bd1b4d@redhat.com> (raw)
In-Reply-To: <20190605121721.29815-3-shmuel.eiderman@oracle.com>
[-- Attachment #1.1: Type: text/plain, Size: 733 bytes --]
On 05.06.19 14:17, Sam Eiderman wrote:
> 512M of L1 entries is a very loose bound, only 32M are required to store
> the maximal supported VMDK file size of 2TB.
>
> Fixed qemu-iotest 59# - now failure occures before on impossible L1
> table size.
>
> Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
> Reviewed-by: Eyal Moscovici <eyal.moscovici@oracle.com>
> Reviewed-by: Liran Alon <liran.alon@oracle.com>
> Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
> Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
> ---
> block/vmdk.c | 13 +++++++------
> tests/qemu-iotests/059.out | 2 +-
> 2 files changed, 8 insertions(+), 7 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-06-19 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 12:17 [Qemu-devel] [PATCH v2 0/3] vmdk: Add read-only support for the new seSparse format Sam Eiderman
2019-06-05 12:17 ` [Qemu-devel] [PATCH v2 1/3] vmdk: Fix comment regarding max l1_size coverage Sam Eiderman
2019-06-19 17:10 ` Max Reitz
2019-06-05 12:17 ` [Qemu-devel] [PATCH v2 2/3] vmdk: Reduce the max bound for L1 table size Sam Eiderman
2019-06-19 17:09 ` Max Reitz [this message]
2019-06-05 12:17 ` [Qemu-devel] [PATCH v2 3/3] vmdk: Add read-only support for seSparse snapshots Sam Eiderman
2019-06-19 17:12 ` Max Reitz
2019-06-20 8:48 ` Sam Eiderman
2019-06-19 9:31 ` [Qemu-devel] [PATCH v2 0/3] vmdk: Add read-only support for the new seSparse format Sam Eiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6851ef37-29d0-f74a-32a5-1840a5bd1b4d@redhat.com \
--to=mreitz@redhat.com \
--cc=arbel.moshe@oracle.com \
--cc=eyal.moscovici@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).