From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: thuth@redhat.com, frankja@linux.ibm.com, mst@redhat.com,
david@redhat.com, richard.henderson@linaro.org,
qemu-devel@nongnu.org, Halil Pasic <pasic@linux.ibm.com>,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
marcandre.lureau@redhat.com, pbonzini@redhat.com,
imbrenda@linux.ibm.com
Subject: Re: [PATCH v1 1/1] s390x: css: report errors from ccw_dstream_read/write
Date: Thu, 8 Apr 2021 18:18:32 +0200 [thread overview]
Message-ID: <6859ae7b-9ed0-17ab-ff8d-366cb566eb04@linux.ibm.com> (raw)
In-Reply-To: <20210408152322.70eea267.cohuck@redhat.com>
On 4/8/21 3:23 PM, Cornelia Huck wrote:
> On Thu, 8 Apr 2021 14:32:11 +0200
> Pierre Morel <pmorel@linux.ibm.com> wrote:
>
>> On 4/8/21 11:02 AM, Cornelia Huck wrote:
>>> On Wed, 7 Apr 2021 19:47:11 +0200
>>> Halil Pasic <pasic@linux.ibm.com> wrote:
>>>
>>>> So this begs the question, do we need this fixed for old releases as well?
>>>>
>>>> My answer is yes we do. Conny what do you think?
>>>
>>> What do you mean with "old releases"? The dstream rework was in 2.11,
>>> and I doubt that anyone is using anything older, or a downstream
>>> release that is based on pre-2.11.
>>>
>>> If you mean "include in stable", then yes, we can do that; if we want
>>> the commit in 6.0, I need the final version soon.
>>>
>>>
>>
>> OK, are you OK with the two change propositions I sent?
>>
>> 1) let the 3270 decide for internal errors (-EIO) but return the error
>> for CSS errors in handle_payload_3270_write()
>>
>> 2) for senseid, always ask CSS to update the residual count
>> but only erase the senseid if the write succeeded
>>
>>
>
> I think both make sense.
>
OK I send a v2
Thanks
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2021-04-08 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 7:44 [PATCH v1 0/1] s390x: css: report errors from ccw_dstream_read/write Pierre Morel
2021-04-06 7:44 ` [PATCH v1 1/1] " Pierre Morel
2021-04-06 15:03 ` Cornelia Huck
2021-04-07 11:41 ` Pierre Morel
2021-04-07 16:54 ` Halil Pasic
2021-04-08 8:53 ` Cornelia Huck
2021-04-07 17:47 ` Halil Pasic
2021-04-08 9:02 ` Cornelia Huck
2021-04-08 12:32 ` Pierre Morel
2021-04-08 13:23 ` Cornelia Huck
2021-04-08 16:18 ` Pierre Morel [this message]
2021-04-08 12:39 ` Halil Pasic
2021-04-08 13:26 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6859ae7b-9ed0-17ab-ff8d-366cb566eb04@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).