From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81EE8C43461 for ; Tue, 18 May 2021 04:43:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC63561004 for ; Tue, 18 May 2021 04:43:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC63561004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lira3-0000VB-2y for qemu-devel@archiver.kernel.org; Tue, 18 May 2021 00:43:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lirZ5-000820-BN; Tue, 18 May 2021 00:42:43 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lirZ2-00051k-F9; Tue, 18 May 2021 00:42:43 -0400 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fkjw269QMz16Pph; Tue, 18 May 2021 12:39:46 +0800 (CST) Received: from dggpemm500023.china.huawei.com (7.185.36.83) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 18 May 2021 12:42:31 +0800 Received: from [10.174.187.128] (10.174.187.128) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 18 May 2021 12:42:30 +0800 Subject: Re: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members To: Salil Mehta References: <20210516102900.28036-1-wangyanan55@huawei.com> <20210516102900.28036-5-wangyanan55@huawei.com> <6c8f9c3502384f648f30c7381e87dda9@huawei.com> From: "wangyanan (Y)" Message-ID: <68883a1b-5303-da13-a051-e909e1d1f71b@huawei.com> Date: Tue, 18 May 2021 12:42:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <6c8f9c3502384f648f30c7381e87dda9@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.187.128] X-ClientProxiedBy: dggeme720-chm.china.huawei.com (10.1.199.116) To dggpemm500023.china.huawei.com (7.185.36.83) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.190; envelope-from=wangyanan55@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , Peter Maydell , Andrew Jones , "Michael S . Tsirkin" , "wanghaibin.wang@huawei.com" , Keqian Zhu , qemu-devel@nongnu.org, yangyicong@huawei.com, Shannon Zhao , qemu-arm@nongnu.org, Alistair Francis , prime.zeng@hisilicon.com, Paolo Bonzini , yuzenghui@huawei.com, Igor Mammedov , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Salil, On 2021/5/18 4:48, Salil Mehta wrote: >> From: Qemu-arm [mailto:qemu-arm-bounces+salil.mehta=huawei.com@nongnu.org] >> On Behalf Of Yanan Wang >> Sent: Sunday, May 16, 2021 11:29 AM >> To: Peter Maydell ; Andrew Jones >> ; Michael S . Tsirkin ; Igor Mammedov >> ; Shannon Zhao ; Alistair >> Francis ; David Gibson >> ; qemu-devel@nongnu.org; qemu-arm@nongnu.org >> Cc: Song Bao Hua (Barry Song) ; zhukeqian >> ; yangyicong ; Zengtao (B) >> ; Wanghaibin (D) ; >> yuzenghui ; Paolo Bonzini ; >> Philippe Mathieu-Daudé >> Subject: [RFC PATCH v3 4/9] hw/arm/virt: Initialize the present cpu members >> >> We create and initialize a cpuobj for each present cpu in >> machvirt_init(). Now we also initialize the cpu member of >> structure CPUArchId for each present cpu in the function. > [...] > >> qdev_realize(DEVICE(cpuobj), NULL, &error_fatal); >> + >> + /* >> + * As ARM cpu hotplug is not supported yet, we initialize >> + * the present cpu members here. >> + */ >> + machine->possible_cpus->cpus[n].cpu = cpuobj; > > when vcpu Hotplug is not supported yet, what necessitates this change now? > The initialization will gives a way to determine whether a CPU is present or not. At least, for now it will be used when generating ACPI tables, e.g. DSDT, MADT. See patch 5 and 6. Thanks, Yanan > .