From: Kamil Rytarowski <n54@gmx.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v6 3/4] tests/vm: use console_consume for netbsd
Date: Thu, 31 Oct 2019 11:22:02 +0100 [thread overview]
Message-ID: <6999581f-907c-ccea-5b55-b7be826a9fe9@gmx.com> (raw)
In-Reply-To: <20191031085306.28888-4-kraxel@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 877 bytes --]
Thank you for this work. I hope it will be fine now.
On 31.10.2019 09:53, Gerd Hoffmann wrote:
> Use new helper to read all pending console output,
> not just a single char. Unblocks installer boot.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> tests/vm/netbsd | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vm/netbsd b/tests/vm/netbsd
> index 5e04dcd9b1..d1bccccfd0 100755
> --- a/tests/vm/netbsd
> +++ b/tests/vm/netbsd
> @@ -93,7 +93,7 @@ class NetBSDVM(basevm.BaseVM):
> for char in list("5consdev com0\n"):
> time.sleep(0.2)
> self.console_send(char)
> - self.console_wait("")
> + self.console_consume()
> self.console_wait_send("> ", "boot\n")
>
> self.console_wait_send("Terminal type", "xterm\n")
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-31 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 8:53 [PATCH v6 0/4] tests/vm: netbsd autoinstall Gerd Hoffmann
2019-10-31 8:53 ` [PATCH v6 1/4] tests/vm: netbsd autoinstall, using serial console Gerd Hoffmann
2019-11-11 14:23 ` Thomas Huth
2019-10-31 8:53 ` [PATCH v6 2/4] tests/vm: add console_consume helper Gerd Hoffmann
2019-10-31 14:05 ` Philippe Mathieu-Daudé
2019-10-31 8:53 ` [PATCH v6 3/4] tests/vm: use console_consume for netbsd Gerd Hoffmann
2019-10-31 10:22 ` Kamil Rytarowski [this message]
2019-10-31 14:06 ` Philippe Mathieu-Daudé
2019-10-31 8:53 ` [PATCH v6 4/4] tests/vm: update netbsd to version 8.1 Gerd Hoffmann
2019-10-31 14:07 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6999581f-907c-ccea-5b55-b7be826a9fe9@gmx.com \
--to=n54@gmx.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).