From: Thomas Huth <thuth@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>, qemu-devel <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Alex Bennee <alex.bennee@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH 2/2] yank: Always link full yank code
Date: Tue, 23 Mar 2021 19:04:49 +0100 [thread overview]
Message-ID: <69b7d24c-8fc6-f3ee-5ed8-999b10a9c2de@redhat.com> (raw)
In-Reply-To: <997aa12a28c555d8a3b7a363b3bda5c3cf1821ba.1616521341.git.lukasstraub2@web.de>
On 23/03/2021 18.52, Lukas Straub wrote:
> Yank now only depends on util and can be always linked in. Also remove
> the stubs as they are not needed anymore.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
> ---
> MAINTAINERS | 1 -
> stubs/meson.build | 1 -
> stubs/yank.c | 23 -----------------------
> util/meson.build | 2 +-
> 4 files changed, 1 insertion(+), 26 deletions(-)
> delete mode 100644 stubs/yank.c
This indeed looks like the best solution to me. Thanks!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-03-23 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 17:52 [PATCH 0/2] yank: Always link full yank code Lukas Straub
2021-03-23 17:52 ` [PATCH 1/2] yank: Remove dependency on qiochannel Lukas Straub
2021-03-23 18:03 ` Thomas Huth
2021-03-25 20:29 ` Marc-André Lureau
2021-03-23 17:52 ` [PATCH 2/2] yank: Always link full yank code Lukas Straub
2021-03-23 18:04 ` Thomas Huth [this message]
2021-03-25 20:30 ` Marc-André Lureau
2021-03-23 19:09 ` [PATCH 0/2] " Daniel P. Berrangé
2021-03-24 11:22 ` Lukas Straub
2021-03-24 11:36 ` Daniel P. Berrangé
2021-03-24 12:09 ` Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69b7d24c-8fc6-f3ee-5ed8-999b10a9c2de@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=lukasstraub2@web.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).