From: Laurent Vivier <laurent@vivier.eu>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-trivial@nongnu.org, Juan Quintela <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: fix naming scheme of compatiblity arrays
Date: Wed, 21 Aug 2019 10:29:28 +0200 [thread overview]
Message-ID: <6a282568-ec94-2270-c72a-34658acaba8b@vivier.eu> (raw)
In-Reply-To: <20190708204909.10891-1-marcandre.lureau@redhat.com>
Le 08/07/2019 à 22:49, Marc-André Lureau a écrit :
> Since merge 31ed41889e6e13699871040fe089a2884dca46cb ("Merge
> remote-tracking branch
> 'remotes/elmarco/tags/machine-props-pull-request' into staging"), the
> compat arrays are in lowercase.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> docs/devel/migration.rst | 2 +-
> hw/i386/pc_piix.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
> index 220059679a..f7668ae389 100644
> --- a/docs/devel/migration.rst
> +++ b/docs/devel/migration.rst
> @@ -314,7 +314,7 @@ For example:
>
> a) Add a new property using ``DEFINE_PROP_BOOL`` - e.g. support-foo and
> default it to true.
> - b) Add an entry to the ``HW_COMPAT_`` for the previous version that sets
> + b) Add an entry to the ``hw_compat_`` for the previous version that sets
> the property to false.
> c) Add a static bool support_foo function that tests the property.
> d) Add a subsection with a .needed set to the support_foo function
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index c2280c72ef..6a0e29de7c 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -313,7 +313,7 @@ else {
> * pc_compat_*() functions that run on machine-init time and
> * change global QEMU state are deprecated. Please don't create
> * one, and implement any pc-*-2.4 (and newer) compat code in
> - * HW_COMPAT_*, PC_COMPAT_*, or * pc_*_machine_options().
> + * hw_compat_*, pc_compat_*, or * pc_*_machine_options().
> */
>
> static void pc_compat_2_3_fn(MachineState *machine)
>
Applied to my trivial-patches branch.
Thanks,
Laurent
prev parent reply other threads:[~2019-08-21 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 20:49 [Qemu-devel] [PATCH] misc: fix naming scheme of compatiblity arrays Marc-André Lureau
2019-07-09 8:47 ` Stefano Garzarella
2019-08-21 8:29 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a282568-ec94-2270-c72a-34658acaba8b@vivier.eu \
--to=laurent@vivier.eu \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).