qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/8] q800: move VIA1 IRQ from level 1 to level 6
Date: Fri, 15 Oct 2021 08:24:34 +0200	[thread overview]
Message-ID: <6a293640-8bda-beb0-3e4c-35e50d5c5974@vivier.eu> (raw)
In-Reply-To: <20211013212132.31519-3-mark.cave-ayland@ilande.co.uk>

Le 13/10/2021 à 23:21, Mark Cave-Ayland a écrit :
> On a Quadra 800 machine Linux sets via_alt_mapping to 1 and clears port B bit 6 to
> ensure that the VIA1 IRQ is delivered at level 6 rather than level 1. Even though
> QEMU doesn't yet emulate this behaviour, Linux still installs the VIA1 level 1 IRQ
> handler regardless of the value of via_alt_mapping which is why the kernel has been
> able to boot until now.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/m68k/q800.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> index fd4855047e..15f3067811 100644
> --- a/hw/m68k/q800.c
> +++ b/hw/m68k/q800.c
> @@ -284,7 +284,7 @@ static void q800_init(MachineState *machine)
>      sysbus = SYS_BUS_DEVICE(via1_dev);
>      sysbus_realize_and_unref(sysbus, &error_fatal);
>      sysbus_mmio_map(sysbus, 1, VIA_BASE);
> -    sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in(glue, 0));
> +    sysbus_connect_irq(sysbus, 0, qdev_get_gpio_in(glue, 5));
>  
>      adb_bus = qdev_get_child_bus(via1_dev, "adb.0");
>      dev = qdev_new(TYPE_ADB_KEYBOARD);
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>


  reply	other threads:[~2021-10-15  6:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 21:21 [PATCH 0/8] q800: GLUE updates for A/UX mode Mark Cave-Ayland
2021-10-13 21:21 ` [PATCH 1/8] mac_via: update comment for VIA1B_vMystery bit Mark Cave-Ayland
2021-10-15  6:14   ` Laurent Vivier
2021-10-15 19:30     ` Mark Cave-Ayland
2021-10-13 21:21 ` [PATCH 2/8] q800: move VIA1 IRQ from level 1 to level 6 Mark Cave-Ayland
2021-10-15  6:24   ` Laurent Vivier [this message]
2021-10-13 21:21 ` [PATCH 3/8] q800: use GLUE IRQ numbers instead of IRQ level for GLUE IRQs Mark Cave-Ayland
2021-10-15  6:31   ` Laurent Vivier
2021-10-15  8:51     ` BALATON Zoltan
2021-10-15 19:42     ` Mark Cave-Ayland
2021-10-17  9:40     ` Mark Cave-Ayland
2021-10-17 13:30       ` Laurent Vivier
2021-10-13 21:21 ` [PATCH 4/8] mac_via: add GPIO for A/UX mode Mark Cave-Ayland
2021-10-15  6:58   ` Laurent Vivier
2021-10-15 19:50     ` Mark Cave-Ayland
2021-10-16 17:04       ` Laurent Vivier
2021-10-15  7:17   ` Laurent Vivier
2021-10-15 19:59     ` Mark Cave-Ayland
2021-10-16 17:06       ` Laurent Vivier
2021-10-13 21:21 ` [PATCH 5/8] q800: wire up auxmode GPIO to GLUE Mark Cave-Ayland
2021-10-15  7:01   ` Laurent Vivier
2021-10-16 18:00   ` Laurent Vivier
2021-10-13 21:21 ` [PATCH 6/8] q800: route SONIC on-board Ethernet IRQ via nubus IRQ 9 in classic mode Mark Cave-Ayland
2021-10-16 18:08   ` Laurent Vivier
2021-10-17 10:07     ` Mark Cave-Ayland
2021-10-13 21:21 ` [PATCH 7/8] q800: wire up remaining IRQs " Mark Cave-Ayland
2021-10-16 18:09   ` Laurent Vivier
2021-10-13 21:21 ` [PATCH 8/8] q800: add NMI handler Mark Cave-Ayland
2021-10-15  8:40   ` Laurent Vivier
2021-10-15 20:12     ` Mark Cave-Ayland
2021-10-16 17:09       ` Laurent Vivier
2021-10-17 10:00         ` Mark Cave-Ayland
2021-10-17 16:56           ` Laurent Vivier
2021-10-20 13:32             ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a293640-8bda-beb0-3e4c-35e50d5c5974@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).