From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CF4EC433ED for ; Tue, 20 Apr 2021 10:20:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B6CE611F0 for ; Tue, 20 Apr 2021 10:20:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B6CE611F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYnUU-0002fW-0i for qemu-devel@archiver.kernel.org; Tue, 20 Apr 2021 06:20:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYnSv-00027T-Oi for qemu-devel@nongnu.org; Tue, 20 Apr 2021 06:18:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44197) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYnSr-0001JL-Gw for qemu-devel@nongnu.org; Tue, 20 Apr 2021 06:18:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618913920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VHz0dZF3qRUaF/BqQApic7OjVIZOr5upqJo5PWk9HQM=; b=ArLotxPJi29T4S1JC9OAzOcczdTY8TfiIZRG52l9PI4JYvS8UIyykM+TT0FV5BIadHpcpw g30CHKt7uoQw2cOZ4fYoPtsvXXMGuPY30YnyyYkK0fGhn5ahssrw2Rf1EzZr4nd2foNVjW H/3llyFXxC0G+7x8ySvzRfJhPsk4Iww= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-JGQyTm7uMeuw_Fbas3yENw-1; Tue, 20 Apr 2021 06:18:38 -0400 X-MC-Unique: JGQyTm7uMeuw_Fbas3yENw-1 Received: by mail-wm1-f72.google.com with SMTP id c124-20020a1c9a820000b0290136c7a94cf3so906028wme.3 for ; Tue, 20 Apr 2021 03:18:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VHz0dZF3qRUaF/BqQApic7OjVIZOr5upqJo5PWk9HQM=; b=gy07qVwdNe3F87IUZUWcebqoRmF/Nw3yfyv31Cqxbe0Uwez6cqOTOEcWBEkFmBe+JU Qg5Jg3awWzqt+5+qnd5J1CJsjm3uHpk6YyF1+LnPaJPDOAoqBQhs5oWOOdgWcnmM+C9C m9zDsbXO+o5dosJQHmSrPiyTJ6HmVVshHVNjyQ6c3mwFMTGCA2SkuQxt3aNHPpg0snhg Qf4zNrpQmX/IVHjx5ywJf2g1JYfzxkhOWwFzGr7YChU5ZfjnckhbDJt8CbABuiJlhgj3 QE0+gUAgrvmdfsCxNozk5NPLIz5mIhFanPHCfCHDigKkJB7L9kIWi7MFgRJkSH4N/H8e i6lA== X-Gm-Message-State: AOAM532VhmO11RfII1h+PTvkqDny9dZXSFFMct1f3EzdpnRtvb/5vXXn 2/4n4EiP3vWveZU5N+G6D8IYbcfL0bpG41iJzR0hGhVzDsfV0WrbGlJMJRYDI1YTmBTMASbWHo0 C1U3kD5TtGjvw37M= X-Received: by 2002:a05:6000:1204:: with SMTP id e4mr19562918wrx.424.1618913917780; Tue, 20 Apr 2021 03:18:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX/gfBAa0MFKw3+LvYpIekIL8MgsIYIqQ1RVEgjXKCJycwFkJLyuKDY7TO3EU+uImdI78XDw== X-Received: by 2002:a05:6000:1204:: with SMTP id e4mr19562895wrx.424.1618913917610; Tue, 20 Apr 2021 03:18:37 -0700 (PDT) Received: from [192.168.1.36] (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id a22sm25615901wrc.59.2021.04.20.03.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Apr 2021 03:18:36 -0700 (PDT) Subject: Re: [PATCH v5 04/14] softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd() From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= To: David Hildenbrand , qemu-devel@nongnu.org References: <20210413091421.7707-1-david@redhat.com> <20210413091421.7707-5-david@redhat.com> <83201a21-7f05-88dd-abc7-59576bce2fe9@redhat.com> Message-ID: <6ab168bd-113c-6fcb-658a-70f71aca4ab0@redhat.com> Date: Tue, 20 Apr 2021 12:18:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <83201a21-7f05-88dd-abc7-59576bce2fe9@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Eduardo Habkost , "Michael S. Tsirkin" , Murilo Opsfelder Araujo , Richard Henderson , "Dr. David Alan Gilbert" , Peter Xu , Greg Kurz , Stefan Hajnoczi , Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi David, On 4/20/21 11:52 AM, Philippe Mathieu-Daudé wrote: > On 4/13/21 11:14 AM, David Hildenbrand wrote: >> Let's pass in ram flags just like we do with qemu_ram_alloc_from_file(), >> to clean up and prepare for more flags. >> >> Simplify the documentation of passed ram flags: Looking at our >> documentation of RAM_SHARED and RAM_PMEM is sufficient, no need to be >> repetitive. >> >> Reviewed-by: Peter Xu >> Signed-off-by: David Hildenbrand >> --- >> backends/hostmem-memfd.c | 7 ++++--- >> hw/misc/ivshmem.c | 5 ++--- >> include/exec/memory.h | 9 +++------ >> include/exec/ram_addr.h | 6 +----- >> softmmu/memory.c | 7 +++---- >> 5 files changed, 13 insertions(+), 21 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé > Actually it would be clearer to define the 0 value, maybe: #define RAM_NOFLAG (0 << 0)