From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v6 07/11] iotests: add findtests.py
Date: Wed, 13 Jan 2021 17:10:29 -0600 [thread overview]
Message-ID: <6c036c30-b0b7-dcb8-7161-c5771eff131b@redhat.com> (raw)
In-Reply-To: <20210109122631.167314-8-vsementsov@virtuozzo.com>
On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> Add python script with new logic of searching for tests:
>
> Current ./check behavior:
> - tests are named [0-9][0-9][0-9]
> - tests must be registered in group file (even if test doesn't belong
> to any group, like 142)
>
>
> This commit don't update check behavior (which will be don in further
done
> commit), still, the documentation changed like new behavior is already
> here. Let's live with this small inconsistency for the following few
> commits, until final change.
>
> The file findtests.py is self-executable and may be used for debugging
> purposes.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> docs/devel/testing.rst | 50 ++++++-
> tests/qemu-iotests/findtests.py | 229 ++++++++++++++++++++++++++++++++
> 2 files changed, 278 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/findtests.py
In addition to Kevin's review,
> +Additional way of defining groups is creating tests/qemu-iotests/group.local
> +file. This should be used only for downstream (this file should never appear
> +in upstream). This file may be used for defining some downstream test groups
> +or for temporary disable tests, like this:
Kevin suggested s/disable/disabling/; I'd go one step further:
/temporary disable/temporarily disabling/
> +
> +- quick : Tests in this group should finish within some few seconds.
s/some/a/
Also, for each group name, the space before ':' looks odd.
> +++ b/tests/qemu-iotests/findtests.py
> @@ -0,0 +1,229 @@
> +#!/usr/bin/env python3
> +#
> +# Parse command line options to define set of tests to run.
> +#
> +# Copyright (c) 2020 Virtuozzo International GmbH
Worth claiming 2021 as well?
Otherwise, my python review is weak, but I didn't spot anything
blatantly wrong.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2021-01-13 23:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 12:26 [PATCH v6 00/11] Rework iotests/check Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:37 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running Vladimir Sementsov-Ogievskiy
2021-01-13 22:38 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 03/11] iotests: fix some whitespaces in test output files Vladimir Sementsov-Ogievskiy
2021-01-13 22:51 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 04/11] iotests: make tests executable Vladimir Sementsov-Ogievskiy
2021-01-13 22:53 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 05/11] iotests/294: add shebang line Vladimir Sementsov-Ogievskiy
2021-01-13 22:54 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 06/11] iotests: define group in each iotest Vladimir Sementsov-Ogievskiy
2021-01-13 23:01 ` Eric Blake
2021-01-09 12:26 ` [PATCH v6 07/11] iotests: add findtests.py Vladimir Sementsov-Ogievskiy
2021-01-12 16:42 ` Kevin Wolf
2021-01-13 10:37 ` Vladimir Sementsov-Ogievskiy
2021-01-13 11:18 ` Kevin Wolf
2021-01-14 7:38 ` Vladimir Sementsov-Ogievskiy
2021-01-14 10:48 ` Kevin Wolf
2021-01-13 23:10 ` Eric Blake [this message]
2021-01-09 12:26 ` [PATCH v6 08/11] iotests: add testenv.py Vladimir Sementsov-Ogievskiy
2021-01-12 17:36 ` Kevin Wolf
2021-01-14 6:14 ` Vladimir Sementsov-Ogievskiy
2021-01-14 6:16 ` Vladimir Sementsov-Ogievskiy
2021-01-14 4:28 ` Vladimir Sementsov-Ogievskiy
2021-01-14 11:14 ` Kevin Wolf
2021-01-14 11:26 ` Vladimir Sementsov-Ogievskiy
2021-01-15 11:18 ` Kevin Wolf
2021-01-15 12:19 ` Vladimir Sementsov-Ogievskiy
2021-01-15 12:45 ` Kevin Wolf
2021-01-15 13:10 ` Vladimir Sementsov-Ogievskiy
2021-01-15 13:20 ` Kevin Wolf
2021-01-15 13:30 ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:03 ` Vladimir Sementsov-Ogievskiy
2021-01-16 11:19 ` Vladimir Sementsov-Ogievskiy
2021-01-18 9:59 ` Kevin Wolf
2021-01-18 17:00 ` Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 09/11] iotests: add testrunner.py Vladimir Sementsov-Ogievskiy
2021-01-09 12:26 ` [PATCH v6 10/11] iotests: rewrite check into python Vladimir Sementsov-Ogievskiy
2021-01-12 17:41 ` Kevin Wolf
2021-01-13 23:20 ` Eric Blake
2021-01-14 0:18 ` John Snow
2021-01-09 12:26 ` [PATCH v6 11/11] iotests: rename and move 169 and 199 tests Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c036c30-b0b7-dcb8-7161-c5771eff131b@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).