From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, fam@euphon.net, libvir-list@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, stefanha@redhat.com,
den@openvz.org, jsnow@redhat.com
Subject: Re: [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver
Date: Wed, 14 Oct 2020 18:27:22 +0200 [thread overview]
Message-ID: <6d39eb6f-4a64-62be-9d28-fc5c7cfd2ae7@redhat.com> (raw)
In-Reply-To: <380352ca-2450-e4be-885f-c826296618df@virtuozzo.com>
[-- Attachment #1.1: Type: text/plain, Size: 2702 bytes --]
On 14.10.20 16:56, Vladimir Sementsov-Ogievskiy wrote:
> 14.10.2020 14:57, Max Reitz wrote:
>> On 14.10.20 13:09, Max Reitz wrote:
>>> On 12.10.20 19:43, Andrey Shinkevich wrote:
>>>> We are going to use the COR-filter for a block-stream job.
>>>> To limit COR operations by the base node in the backing chain during
>>>> stream job, pass the name of overlay base node to the copy-on-read
>>>> driver as base node itself may change due to possible concurrent jobs.
>>>> The rest of the functionality will be implemented in the patch that
>>>> follows.
>>>>
>>>> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
>>>> ---
>>>> block/copy-on-read.c | 14 ++++++++++++++
>>>> 1 file changed, 14 insertions(+)
>>>
>>> Is there a reason why you didn’t add this option to QAPI (as part of a
>>> yet-to-be-created BlockdevOptionsCor)? Because I’d really like it
>>> there.
>>>
>>>> diff --git a/block/copy-on-read.c b/block/copy-on-read.c
>>>> index bcccf0f..c578b1b 100644
>>>> --- a/block/copy-on-read.c
>>>> +++ b/block/copy-on-read.c
>>>> @@ -24,19 +24,24 @@
>>>> #include "block/block_int.h"
>>>> #include "qemu/module.h"
>>>> #include "qapi/error.h"
>>>> +#include "qapi/qmp/qerror.h"
>>>> #include "qapi/qmp/qdict.h"
>>>> #include "block/copy-on-read.h"
>>>> typedef struct BDRVStateCOR {
>>>> bool active;
>>>> + BlockDriverState *base_overlay;
>>>> } BDRVStateCOR;
>>>> static int cor_open(BlockDriverState *bs, QDict *options, int
>>>> flags,
>>>> Error **errp)
>>>> {
>>>> + BlockDriverState *base_overlay = NULL;
>>>> BDRVStateCOR *state = bs->opaque;
>>>> + /* We need the base overlay node rather than the base itself */
>>>> + const char *base_overlay_node = qdict_get_try_str(options,
>>>> "base");
>>>
>>> Shouldn’t it be called base-overlay or above-base then?
>>
>> While reviewing patch 5, I realized this sould indeed be base-overlay
(Just realized that sounds different from how I meant it. I meant that
“above-base” would be wrong, so from the two, if any, it should be
“base-overlay”.)
>> (i.e. the next allocation-bearing layer above the base, not just a
>> filter on top of base), but that should be noted somewhere, of course.
>> Best would be the QAPI documentation for this option. O:)
>>
>
> What about naming it just "bottom" or "bottom-node"? If we don't have
> base, it's strange to have something "relative to base". And we can
> document, that "bottom" must be a non-filter node in a backing chain of
> "top".
Works for me, too.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-10-14 16:30 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 17:43 [PATCH v11 00/13] Apply COR-filter to the block-stream permanently Andrey Shinkevich via
2020-10-12 17:43 ` [PATCH v11 01/13] copy-on-read: Support preadv/pwritev_part functions Andrey Shinkevich via
2020-10-12 17:43 ` [PATCH v11 02/13] copy-on-read: add filter append/drop functions Andrey Shinkevich via
2020-10-14 10:44 ` Max Reitz
2020-10-14 14:28 ` Andrey Shinkevich
2020-10-14 16:26 ` Max Reitz
2020-10-12 17:43 ` [PATCH v11 03/13] qapi: add filter-node-name to block-stream Andrey Shinkevich via
2020-10-12 17:43 ` [PATCH v11 04/13] copy-on-read: pass overlay base node name to COR driver Andrey Shinkevich via
2020-10-14 11:09 ` Max Reitz
2020-10-14 11:57 ` Max Reitz
2020-10-14 14:56 ` Vladimir Sementsov-Ogievskiy
2020-10-14 16:27 ` Max Reitz [this message]
2020-10-14 16:08 ` Andrey Shinkevich
2020-10-14 16:18 ` Vladimir Sementsov-Ogievskiy
2020-10-14 16:36 ` Max Reitz
2020-10-12 17:43 ` [PATCH v11 05/13] copy-on-read: limit COR operations to base in " Andrey Shinkevich via
2020-10-14 11:59 ` Max Reitz
2020-10-14 17:43 ` Andrey Shinkevich
2020-10-14 12:01 ` Max Reitz
2020-10-14 18:57 ` Andrey Shinkevich
2020-10-15 15:56 ` Max Reitz
2020-10-15 17:37 ` Andrey Shinkevich
2020-10-16 14:28 ` Vladimir Sementsov-Ogievskiy
2020-10-12 17:43 ` [PATCH v11 06/13] block: modify the comment for BDRV_REQ_PREFETCH flag Andrey Shinkevich via
2020-10-14 12:22 ` Max Reitz
2020-10-14 15:04 ` Vladimir Sementsov-Ogievskiy
2020-10-14 19:57 ` Andrey Shinkevich
2020-10-12 17:43 ` [PATCH v11 07/13] block: include supported_read_flags into BDS structure Andrey Shinkevich via
2020-10-14 12:31 ` Max Reitz
2020-10-12 17:43 ` [PATCH v11 08/13] copy-on-read: add support for BDRV_REQ_PREFETCH to COR-filter Andrey Shinkevich via
2020-10-14 12:40 ` Max Reitz
2020-10-12 17:43 ` [PATCH v11 09/13] copy-on-read: skip non-guest reads if no copy needed Andrey Shinkevich via
2020-10-14 12:51 ` Max Reitz
2020-10-14 15:22 ` Vladimir Sementsov-Ogievskiy
2020-10-14 16:30 ` Max Reitz
2020-10-14 16:39 ` Vladimir Sementsov-Ogievskiy
2020-10-15 15:49 ` Max Reitz
2020-10-21 20:43 ` Andrey Shinkevich
2020-10-22 7:50 ` Andrey Shinkevich
2020-10-22 8:56 ` Vladimir Sementsov-Ogievskiy
2020-10-14 20:49 ` Andrey Shinkevich
2020-10-12 17:43 ` [PATCH v11 10/13] stream: skip filters when writing backing file name to QCOW2 header Andrey Shinkevich via
2020-10-14 15:02 ` Max Reitz
2020-10-14 15:40 ` Vladimir Sementsov-Ogievskiy
2020-10-12 17:43 ` [PATCH v11 11/13] stream: mark backing-file argument as deprecated Andrey Shinkevich via
2020-10-14 15:03 ` Max Reitz
2020-10-14 15:43 ` Vladimir Sementsov-Ogievskiy
2020-10-15 9:01 ` Andrey Shinkevich
2020-10-12 17:43 ` [PATCH v11 12/13] stream: remove unused backing-file name parameter Andrey Shinkevich via
2020-10-14 15:05 ` Max Reitz
2020-10-12 17:43 ` [PATCH v11 13/13] block: apply COR-filter to block-stream jobs Andrey Shinkevich via
2020-10-14 16:24 ` Max Reitz
2020-10-15 17:16 ` Andrey Shinkevich
2020-10-16 15:06 ` Andrey Shinkevich
2020-10-16 15:45 ` Vladimir Sementsov-Ogievskiy
2020-10-20 19:43 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d39eb6f-4a64-62be-9d28-fc5c7cfd2ae7@redhat.com \
--to=mreitz@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).