From: Michael Tokarev <mjt@tls.msk.ru>
To: Cindy Lu <lulu@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-stable@nongnu.org
Subject: Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC
Date: Thu, 30 Sep 2021 13:46:09 +0300 [thread overview]
Message-ID: <6e7328e3-7cee-a99b-ebe9-dd4d9507495a@msgid.tls.msk.ru> (raw)
In-Reply-To: <CACLfguVsjZbDo0JXMHJeNSusOyimajOABBG66T6tm32QN=ihEw@mail.gmail.com>
30.09.2021 04:35, Cindy Lu wrote:
[]
> so here come to the final question. which mac address has the higher priority?
> I think the NET_F_MAC bit means the hw mac address > command-line address.
> if the hw drivers want to change this. they can simply remove this bit.
At the very least, qemu should NEVER silently ignore stuff specified
on the command line. It should either warn the user or error out if
command-line parameter can not be applied for whatever reason.
I don't know the context, what NET_F_MAC is, but the general rule is
this: if the user specified something, it must not be ignored.
/mjt
prev parent reply other threads:[~2021-09-30 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:52 [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC Cindy Lu
2021-09-29 10:01 ` Michael Tokarev
2021-09-29 12:08 ` Cindy Lu
2021-09-29 13:36 ` Michael S. Tsirkin
2021-09-30 1:35 ` Cindy Lu
2021-09-30 10:46 ` Michael Tokarev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e7328e3-7cee-a99b-ebe9-dd4d9507495a@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).