From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, pbonzini@redhat.com,
f4bug@amsat.org, robhenry@microsoft.com,
aaron@os.amperecomputing.com, mahmoudabdalghany@outlook.com,
minyihh@uci.edu, cota@braap.org, stefanha@redhat.com,
crosa@redhat.com, kuhn.chenqun@huawei.com, ma.mandourr@gmail.com,
aurelien@aurel32.net
Subject: Re: [PATCH v2 26/39] tests/tcg: make test-mmap a little less aggressive
Date: Fri, 9 Jul 2021 09:15:36 +0200 [thread overview]
Message-ID: <6fb9e8bd-5b49-21d8-a7f5-fecf7e4e9962@redhat.com> (raw)
In-Reply-To: <20210708190941.16980-27-alex.bennee@linaro.org>
On 08/07/2021 21.09, Alex Bennée wrote:
> The check_aligned_anonymous_unfixed_mmaps and
> check_aligned_anonymous_unfixed_colliding_mmaps do a lot of mmap's and
> copying of data. This is especially unfriendly to targets like hexagon
> which have quite large pages and need to do sanity checks on each
> memory access.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/tcg/multiarch/test-mmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/tcg/multiarch/test-mmap.c b/tests/tcg/multiarch/test-mmap.c
> index 11d0e777b1..b77deee37e 100644
> --- a/tests/tcg/multiarch/test-mmap.c
> +++ b/tests/tcg/multiarch/test-mmap.c
> @@ -58,12 +58,12 @@ void check_aligned_anonymous_unfixed_mmaps(void)
> int i;
>
> fprintf(stdout, "%s", __func__);
> - for (i = 0; i < 0x1fff; i++)
> + for (i = 0; i < 0x1ff; i++)
> {
While you're at it, you could also fix the coding style here and put the
curly bracket on the right hand side of the for-statement.
> size_t len;
>
> len = pagesize + (pagesize * i & 7);
> - p1 = mmap(NULL, len, PROT_READ,
> + p1 = mmap(NULL, len, PROT_READ,
> MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> p2 = mmap(NULL, len, PROT_READ,
> MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> @@ -142,7 +142,7 @@ void check_aligned_anonymous_unfixed_colliding_mmaps(void)
> int i;
>
> fprintf(stdout, "%s", __func__);
> - for (i = 0; i < 0x2fff; i++)
> + for (i = 0; i < 0x2ff; i++)
dito
> {
> int nlen;
> p1 = mmap(NULL, pagesize, PROT_READ,
>
Thomas
next prev parent reply other threads:[~2021-07-09 7:17 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 19:09 [PATCH v2 for 6.1 00/39] testing and plugins pre-PR series Alex Bennée
2021-07-08 19:09 ` [PATCH v2 01/39] Jobs based on custom runners: documentation and configuration placeholder Alex Bennée
2021-07-08 19:09 ` [PATCH v2 02/39] Jobs based on custom runners: build environment docs and playbook Alex Bennée
2021-07-08 19:09 ` [PATCH v2 03/39] Jobs based on custom runners: docs and gitlab-runner setup playbook Alex Bennée
2021-07-08 19:09 ` [PATCH v2 04/39] Jobs based on custom runners: add job definitions for QEMU's machines Alex Bennée
2021-07-08 19:09 ` [PATCH v2 05/39] tests/tcg: also disable the signals test for plugins Alex Bennée
2021-07-08 20:12 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 06/39] build: validate that system capstone works before using it Alex Bennée
2021-07-08 20:14 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 07/39] gitlab: support for FreeBSD 12, 13 and macOS 11 via cirrus-run Alex Bennée
2021-07-08 19:09 ` [PATCH v2 08/39] cirrus: delete FreeBSD and macOS jobs Alex Bennée
2021-07-08 19:09 ` [PATCH v2 09/39] hw/usb/ccid: remove references to NSS Alex Bennée
2021-07-08 19:09 ` [PATCH v2 10/39] tests/docker: don't use BUILDKIT in GitLab either Alex Bennée
2021-07-08 19:09 ` [PATCH v2 11/39] tests/docker: use project specific container registries Alex Bennée
2021-07-08 19:09 ` [PATCH v2 12/39] tests/docker: use explicit docker.io registry Alex Bennée
2021-07-08 19:09 ` [PATCH v2 13/39] tests/docker: remove FEATURES env var from templates Alex Bennée
2021-07-08 19:09 ` [PATCH v2 14/39] tests/docker: fix sorting in package lists Alex Bennée
2021-07-08 19:09 ` [PATCH v2 15/39] tests/docker: fix mistakes in centos " Alex Bennée
2021-07-08 19:09 ` [PATCH v2 16/39] tests/docker: fix mistakes in fedora package list Alex Bennée
2021-07-08 19:09 ` [PATCH v2 17/39] tests/docker: fix mistakes in ubuntu package lists Alex Bennée
2021-07-08 19:09 ` [PATCH v2 18/39] tests/docker: remove mingw packages from Fedora Alex Bennée
2021-07-08 19:09 ` [PATCH v2 19/39] tests/docker: expand centos8 package list Alex Bennée
2021-07-08 19:09 ` [PATCH v2 20/39] tests/docker: expand fedora " Alex Bennée
2021-07-08 19:09 ` [PATCH v2 21/39] tests/docker: expand ubuntu1804 " Alex Bennée
2021-07-08 19:09 ` [PATCH v2 22/39] tests/docker: expand ubuntu2004 " Alex Bennée
2021-07-08 19:09 ` [PATCH v2 23/39] tests/docker: expand opensuse-leap " Alex Bennée
2021-07-08 19:09 ` [PATCH v2 24/39] tests/vm: update NetBSD to 9.2 Alex Bennée
2021-07-08 19:09 ` [PATCH v2 25/39] tests/vm: update openbsd to release 6.9 Alex Bennée
2021-07-08 19:09 ` [PATCH v2 26/39] tests/tcg: make test-mmap a little less aggressive Alex Bennée
2021-07-08 20:29 ` Richard Henderson
2021-07-09 10:51 ` Alex Bennée
2021-07-09 7:15 ` Thomas Huth [this message]
2021-07-08 19:09 ` [PATCH v2 27/39] plugins: fix-up handling of internal hostaddr for 32 bit Alex Bennée
2021-07-08 20:31 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 28/39] meson.build: move TCG plugin summary output Alex Bennée
2021-07-08 19:39 ` Philippe Mathieu-Daudé
2021-07-08 20:31 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 29/39] configure: don't allow plugins to be enabled for a non-TCG build Alex Bennée
2021-07-08 20:32 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 30/39] configure: stop user enabling plugins on Windows for now Alex Bennée
2021-07-08 20:33 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 31/39] tcg/plugins: enable by default for TCG builds Alex Bennée
2021-07-08 20:41 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 32/39] contrib/plugins: enable -Wall for building plugins Alex Bennée
2021-07-08 20:44 ` Richard Henderson
2021-07-08 19:09 ` [PATCH v2 33/39] contrib/plugins: add execlog to log instruction execution and memory access Alex Bennée
2021-07-08 19:09 ` [PATCH v2 34/39] docs/devel: tcg-plugins: add execlog plugin description Alex Bennée
2021-07-08 19:09 ` [PATCH v2 35/39] plugins: Added a new cache modelling plugin Alex Bennée
2021-07-08 19:09 ` [PATCH v2 36/39] plugins/cache: Enable cache parameterization Alex Bennée
2021-07-08 19:09 ` [PATCH v2 37/39] plugins/cache: Added FIFO and LRU eviction policies Alex Bennée
2021-07-08 19:09 ` [PATCH v2 38/39] docs/devel: Added cache plugin to the plugins docs Alex Bennée
2021-07-08 19:09 ` [PATCH v2 39/39] MAINTAINERS: Added myself as a reviewer for TCG Plugins Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb9e8bd-5b49-21d8-a7f5-fecf7e4e9962@redhat.com \
--to=thuth@redhat.com \
--cc=aaron@os.amperecomputing.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=kuhn.chenqun@huawei.com \
--cc=ma.mandourr@gmail.com \
--cc=mahmoudabdalghany@outlook.com \
--cc=minyihh@uci.edu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robhenry@microsoft.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).