From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5BDC433B4 for ; Thu, 13 May 2021 18:26:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C6D36143D for ; Thu, 13 May 2021 18:26:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C6D36143D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=t-online.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhG2K-0000lk-CV for qemu-devel@archiver.kernel.org; Thu, 13 May 2021 14:26:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhFzc-0006d0-Ss; Thu, 13 May 2021 14:23:28 -0400 Received: from mailout07.t-online.de ([194.25.134.83]:55540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhFzT-0001bx-Hi; Thu, 13 May 2021 14:23:28 -0400 Received: from fwd19.aul.t-online.de (fwd19.aul.t-online.de [172.20.27.65]) by mailout07.t-online.de (Postfix) with SMTP id 73BE548FE9; Thu, 13 May 2021 20:23:11 +0200 (CEST) Received: from [192.168.211.200] (VrypukZr8hgbKGyhQXt1h23VkHDuwbbnB5XFoilpvDD-9pcAxGT33gmHMQROdJ0ZK3@[79.208.18.63]) by fwd19.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1lhFzG-1VPP2O0; Thu, 13 May 2021 20:23:06 +0200 Subject: Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210513171244.3940519-1-f4bug@amsat.org> From: =?UTF-8?Q?Volker_R=c3=bcmelin?= Message-ID: <709e2305-39b4-d727-f551-ed38c059290a@t-online.de> Date: Thu, 13 May 2021 20:23:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210513171244.3940519-1-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-ID: VrypukZr8hgbKGyhQXt1h23VkHDuwbbnB5XFoilpvDD-9pcAxGT33gmHMQROdJ0ZK3 X-TOI-EXPURGATEID: 150726::1620930186-0000782A-9055CC5E/0/0 CLEAN NORMAL X-TOI-MSGID: b3adbde5-8d9a-4975-94fd-91279f273b53 Received-SPF: none client-ip=194.25.134.83; envelope-from=vr_qemu@t-online.de; helo=mailout07.t-online.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > Inspired-by: Volker Rümelin > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/input/ps2.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index 72cdb80ae1c..02d7e5da723 100644 > --- a/hw/input/ps2.c > +++ b/hw/input/ps2.c > @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s) > void ps2_queue(PS2State *s, int b) > { > ps2_queue_noirq(s, b); > - s->update_irq(s->update_arg, 1); > + ps2_raise_irq(s); > } > > void ps2_queue_2(PS2State *s, int b1, int b2) > @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2) > > ps2_queue_noirq(s, b1); > ps2_queue_noirq(s, b2); > - s->update_irq(s->update_arg, 1); > + ps2_raise_irq(s); > } > > void ps2_queue_3(PS2State *s, int b1, int b2, int b3) > @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3) > ps2_queue_noirq(s, b1); > ps2_queue_noirq(s, b2); > ps2_queue_noirq(s, b3); > - s->update_irq(s->update_arg, 1); > + ps2_raise_irq(s); > } > > void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4) > @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4) > ps2_queue_noirq(s, b2); > ps2_queue_noirq(s, b3); > ps2_queue_noirq(s, b4); > - s->update_irq(s->update_arg, 1); > + ps2_raise_irq(s); > } > > /* keycode is the untranslated scancode in the current scancode set. */ Hi Philippe, can you read my local qemu repository? :-) Reviewed-by: Volker Rümelin