qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Erik Skultety" <eskultet@redhat.com>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Willian Rampazzo" <willianr@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Miroslav Rezanina" <mrezanin@redhat.com>
Subject: Re: [PATCH 10/15] gitlab-ci: Extract all default build/test jobs to buildtest.yml
Date: Tue, 11 May 2021 09:19:44 +0200	[thread overview]
Message-ID: <70b58436-b153-fa7d-4be8-80cd7c2b4366@amsat.org> (raw)
In-Reply-To: <87a6pu9u65.fsf@linaro.org>

Hi Alex,

On 4/19/21 5:11 PM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> Extract the build/test jobs run by default on the mainstream
>> CI into a new file (buildtest.yml) and their templates into
>> (buildtest-template.yml), to be able to reuse the templates
>> without having to run all these mainstream jobs by default.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>  .gitlab-ci.d/buildtest-template.yml |  80 +++
>>  .gitlab-ci.d/buildtest.yml          | 744 +++++++++++++++++++++++++
>>  .gitlab-ci.yml                      | 824 +---------------------------
>>  3 files changed, 825 insertions(+), 823 deletions(-)
>>  create mode 100644 .gitlab-ci.d/buildtest-template.yml
>>  create mode 100644 .gitlab-ci.d/buildtest.yml

> I don't know if my suggestion further bellow requires moving the above:
> 
>> +build-system-alpine:
>> +check-system-alpine:
>> +acceptance-system-alpine:
> 
> Maybe these can be moved into buildtest-rolling? Or maybe buildtest-[unsupported|other]?

As I temporarily can't test your suggestions, I'll send v2 without
them, and will try to address them on v3 (I am not ignoring them).

> <snip>
> <snip>
> 
>> +build-disabled:
>> +build-tcg-disabled:
> 
> to buildtest-custom?
> 
> 
>> +build-user-plugins:
>> +build-some-softmmu-plugins:
>> +clang-system:
>> +clang-user:
>> +build-cfi-aarch64:
>> +check-cfi-aarch64:
>> +acceptance-cfi-aarch64:
>> +build-cfi-ppc64-s390x:
>> +check-cfi-ppc64-s390x:
>> +acceptance-cfi-ppc64-s390x:
>> +build-cfi-x86_64:
>> +check-cfi-x86_64:
>> +acceptance-cfi-x86_64:
>> +tsan-build:
> 
> to buildtest-developer? is CFI a dev feature or a distro feature?
> Arguably they could be grouped together.
> 
> <snip>
>> +# These targets are on the way out
>> +build-deprecated:
>> +check-deprecated:
> 
> buildtest-developer or even buildtest-deprecated?
> 
> <snip>
>> +gprof-gcov:
>> +build-oss-fuzz:
> 
> buildtest-developer?
> 
>> +build-tci:
>> +build-coroutine-sigaltstack:
> 
> buildtest-custom?
> 
> <snip>
>> +crypto-old-nettle:
>> +crypto-old-gcrypt:
> 
> buildtest-custom or buildtest-legacy?
> 
>> +crypto-only-gnutls:
>> +build-without-default-devices:
>> +build-without-default-features:
> 
> buildtest-custom.
> 
>> +check-patch:
>> +check-dco:
> 
> buildtest-developer or maybe their own pr-qa?
> 
>> +build-libvhost-user:
>> +  stage: build
>> +  image: $CI_REGISTRY_IMAGE/qemu/fedora:latest
>> +  needs:
>> +    job: amd64-fedora-container
>> +  before_script:
>> +    - dnf install -y meson ninja-build
>> +  script:
>> +    - mkdir subprojects/libvhost-user/build
>> +    - cd subprojects/libvhost-user/build
>> +    - meson
>> +    - ninja
> 
> I dunno, buildtest-misc?
> 
>> +# No targets are built here, just tools, docs, and unit tests. This
>> +# also feeds into the eventual documentation deployment steps later
>> +build-tools-and-docs-debian:
>> +pages:
> 
> Seems these could be under their own documentation section?
> 


  reply	other threads:[~2021-05-11  7:20 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-18 23:34 [RFC PATCH 00/15] gitlab-ci: Allow forks to use different pipelines than mainstream Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 01/15] gitlab-ci: Replace YAML anchors by extends (container_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 02/15] gitlab-ci: Replace YAML anchors by extends (native_build_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 03/15] gitlab-ci: Replace YAML anchors by extends (native_test_job) Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 04/15] gitlab-ci: Replace YAML anchors by extends (acceptance_test_job) Philippe Mathieu-Daudé
2021-05-03  9:22   ` Thomas Huth
2021-05-03  9:45     ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 05/15] gitlab-ci: Rename acceptance_test_job -> integration_test_job Philippe Mathieu-Daudé
2021-04-19  5:19   ` Thomas Huth
2021-04-23 17:18     ` Willian Rampazzo
2021-04-18 23:34 ` [PATCH 06/15] gitlab-ci: Extract container job template to container-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 07/15] gitlab-ci: Extract crossbuild job templates to crossbuild-template.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 08/15] gitlab-ci: Extract DCO/style check jobs to checks.yml Philippe Mathieu-Daudé
2021-04-19  5:26   ` Thomas Huth
2021-04-19 13:44     ` Wainer dos Santos Moschetta
2021-04-18 23:34 ` [PATCH 09/15] gitlab-ci: Extract build stages to stages.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [PATCH 10/15] gitlab-ci: Extract all default build/test jobs to buildtest.yml Philippe Mathieu-Daudé
2021-04-19  5:39   ` Thomas Huth
2021-04-19 15:11   ` Alex Bennée
2021-05-11  7:19     ` Philippe Mathieu-Daudé [this message]
2021-04-18 23:34 ` [PATCH 11/15] gitlab-ci: Extract core container jobs to container-core.yml Philippe Mathieu-Daudé
2021-04-19  5:42   ` Thomas Huth
2021-04-18 23:34 ` [PATCH 12/15] gitlab-ci: Move current job set to qemu-project.yml Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 13/15] gitlab-ci: Switch to dynamically generated pipelines Philippe Mathieu-Daudé
2021-04-18 23:34 ` [RFC PATCH 14/15] gitlab-ci: Allow forks to use different set of jobs Philippe Mathieu-Daudé
2021-04-19  5:48   ` Thomas Huth
2021-04-19  9:40   ` Daniel P. Berrangé
2021-04-19 10:09     ` Philippe Mathieu-Daudé
2021-04-19 10:10     ` Erik Skultety
2021-04-19 10:20       ` Thomas Huth
2021-04-19 10:36         ` Daniel P. Berrangé
2021-04-19 10:48           ` Thomas Huth
2021-04-19 10:51             ` Daniel P. Berrangé
2021-04-19 10:59               ` Thomas Huth
2021-05-11  6:48                 ` Philippe Mathieu-Daudé
2021-05-11 13:55                   ` Stefan Hajnoczi
2021-05-11 14:00                   ` Alex Bennée
2021-05-11 14:21                   ` Daniel P. Berrangé
2021-05-13 19:01                   ` Philippe Mathieu-Daudé
2021-04-19 10:47         ` Daniel P. Berrangé
2021-04-19 10:44       ` Philippe Mathieu-Daudé
2021-04-19 15:57   ` Alex Bennée
2021-04-19 16:22     ` Daniel P. Berrangé
2021-04-19 16:46       ` Philippe Mathieu-Daudé
2021-04-19 16:58         ` Daniel P. Berrangé
2021-04-19 16:39     ` Philippe Mathieu-Daudé
2021-04-18 23:34 ` [NOTFORMERGE PATCH 15/15] gitlab-ci: Use my own set of jobs for CI pipeline Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70b58436-b153-fa7d-4be8-80cd7c2b4366@amsat.org \
    --to=f4bug@amsat.org \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=eskultet@redhat.com \
    --cc=mrezanin@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    --subject='Re: [PATCH 10/15] gitlab-ci: Extract all default build/test jobs to buildtest.yml' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox