Re: [PULL v3 00/38] Misc patches (buildsys, i386, fuzzing) for 2021-01-29

[Paolo Bonzini <pbonzini@redhat.com>]

On 02/02/21 14:56, Peter Maydell wrote:
> On Tue, 2 Feb 2021 at 07:48, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> The following changes since commit 74208cd252c5da9d867270a178799abd802b9338:
>>
>>    Merge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-01-29 19:51:25 +0000)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/bonzini/qemu.git tags/for-upstream
>>
>> for you to fetch changes up to a365bda83444f142bb1b9c1b5fdcdefade87981d:
>>
>>    pc-bios/descriptors: fix paths in json files (2021-02-01 17:30:52 +0100)
>>
>> ----------------------------------------------------------------
>> * Fuzzing improvements (Qiuhao, Alexander)
>> * i386: Fix BMI decoding for instructions with the 0x66 prefix (David)
>> * slirp update (Marc-André)
>> * initial attempt at fixing event_notifier emulation (Maxim)
>> * i386: PKS emulation, fix for "qemu-system-i386 -cpu host" (myself)
>> * meson: RBD test fixes (myself)
>> * meson: TCI warnings (Philippe)
>> * Leaner build for --disable-guest-agent, --disable-system and
>>    --disable-tools (Philippe, Stefan)
>> * --enable-tcg-interpreter fix (Richard)
>> * i386: SVM feature bits (Wei)
>> * HVF bugfix (Alex)
>> * KVM bugfix (Thomas)
> 
> Fails to build, x86-64 Linux clang.
> (configure rune:
>   '../../configure' '--cc=clang' '--cxx=clang++' '--enable-gtk'
> '--extra-cflags=-fsanitize=undefined  -fno-sanitize=shift-base
> -Werror')
> 
> clang  -o subprojects/libslirp/libslirp.so.0.2.3
> subprojects/libslirp/libslirp.so.0.2.3.p/src_arp_table.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_bootp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_cksum.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_dhcpv6.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_dnssearch.c.o
> subprojects/libslirp/libslirp.so.0.2
> .3.p/src_if.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip6_icmp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip6_input.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip6_output.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip_icmp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip_input.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ip_output.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_mbuf.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_misc.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ncsi.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_ndp_table.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_sbuf.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_slirp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/
> src_socket.c.o subprojects/libslirp/libslirp.so.0.2.3.p/src_state.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_stream.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_tcp_input.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_tcp_output.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_tcp_subr.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_tcp_timer.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_tftp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_udp.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_udp6.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_util.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_version.c.o
> subprojects/libslirp/libslirp.so.0.2.3.p/src_vmstate.c.o
> -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group
> -Wl,-soname,libslirp.so.0 -Wl,--warn-common -Wl,-z,relro -Wl,-z,now
> -m64 -fsanitize=undefined -fno-sanitize=shift-base -Werror
> -fstack-protector-strong
> -Wl,--version-script,/home/petmay01/linaro/qemu-for-merges/subprojects/libslirp/src/libslirp.map
> -pthread -lgthread-2.0 -lglib-2.0 -Wl,--end-group
> subprojects/libslirp/libslirp.so.0.2.3.p/src_arp_table.c.o: In
> function `arp_table_add':
> /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslirp/src/arp_table.c:50:
> undefined reference to `__ubsan_handle_type_mismatch_v1'
> /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslirp/src/arp_table.c:50:
> undefined reference to `__ubsan_handle_type_mismatch_v1'
> [etc etc etc]
> /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslirp/src/arp_table.c:52:
> undefined reference to `__ubsan_handle_nonnull_arg'
> /home/petmay01/linaro/qemu-for-merges/build/clang/../../subprojects/libslirp/src/arp_table.c:58:
> undefined reference to `__ubsan_handle_type_mismatch_v1'
> [etc etc etc]
> 
> and so on for lots of other libslirp files and ubsan symbols.

Hmm, that should have been taken care of by

     libslirp = subproject('libslirp',
                           default_options: ['default_library=static'])


I'll just drop this change.

Paolo