From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DE1C4361A for ; Fri, 4 Dec 2020 13:53:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF54E22AAD for ; Fri, 4 Dec 2020 13:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF54E22AAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klBWX-0005yK-Hz for qemu-devel@archiver.kernel.org; Fri, 04 Dec 2020 08:53:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klBTq-0003qb-AY for qemu-devel@nongnu.org; Fri, 04 Dec 2020 08:50:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1klBTo-0000h7-NJ for qemu-devel@nongnu.org; Fri, 04 Dec 2020 08:50:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607089836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mytihXFsFzlEFqatQXAUemCMI0bODV4Sgkqz4VTXXvA=; b=WvsklRpHNM+asEmvg9lqk79IrdUVY6tHNeErkoakhCsK+M3j0l/+hYiO/urLfOq/a7wl6p APhqcK9xmf+CLttqJnWIytQVB75IMnxE5Qy+eabvGfyAfnImUCJW1irm0shCxhf7UO7juz 5NAQWe3z4gZmEu2gnSI9qOTMlPm5b7I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-mJ_RFuV-OPaPPjEQX83STg-1; Fri, 04 Dec 2020 08:50:32 -0500 X-MC-Unique: mJ_RFuV-OPaPPjEQX83STg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55769858183; Fri, 4 Dec 2020 13:50:31 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-88.gru2.redhat.com [10.97.116.88]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0BFB100164C; Fri, 4 Dec 2020 13:50:26 +0000 (UTC) Subject: Re: [PATCH 3/3] tests/acceptance: test s390x zpci fid propagation To: Cornelia Huck , qemu-devel@nongnu.org References: <20201130180216.15366-1-cohuck@redhat.com> <20201130180216.15366-4-cohuck@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <728b30ba-7fa9-3ddc-224a-f928320d8232@redhat.com> Date: Fri, 4 Dec 2020 10:50:23 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201130180216.15366-4-cohuck@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.496, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Cleber Rosa , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/30/20 3:02 PM, Cornelia Huck wrote: > Verify that a fid specified on the command line shows up correctly > as the function_id in the guest. > > Signed-off-by: Cornelia Huck > --- > tests/acceptance/machine_s390_ccw_virtio.py | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Wainer dos Santos Moschetta > > diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py > index e203ee304264..53b8484f8f9c 100644 > --- a/tests/acceptance/machine_s390_ccw_virtio.py > +++ b/tests/acceptance/machine_s390_ccw_virtio.py > @@ -56,7 +56,9 @@ class S390CCWVirtioMachine(Test): > '-device', > 'virtio-rng-ccw,devno=fe.3.1234,max_revision=2', > '-device', 'zpci,uid=5,target=zzz', > - '-device', 'virtio-net-pci,id=zzz') > + '-device', 'virtio-net-pci,id=zzz', > + '-device', 'zpci,uid=0xa,fid=12,target=serial', > + '-device', 'virtio-serial-pci,id=serial') > self.vm.launch() > > shell_ready = "sh: can't access tty; job control turned off" > @@ -65,11 +67,11 @@ class S390CCWVirtioMachine(Test): > exec_command_and_wait_for_pattern(self, 'exit', shell_ready) > > ccw_bus_ids="0.1.1111 0.2.0000 0.3.1234" > - pci_bus_id="0005:00:00.0" > + pci_bus_ids="0005:00:00.0 000a:00:00.0" > exec_command_and_wait_for_pattern(self, 'ls /sys/bus/ccw/devices/', > ccw_bus_ids) > exec_command_and_wait_for_pattern(self, 'ls /sys/bus/pci/devices/', > - pci_bus_id) > + pci_bus_ids) > # check that the device at 0.2.0000 is in legacy mode, while the > # device at 0.3.1234 has the virtio-1 feature bit set > virtio_rng_features="0000000000000000000000000000110010000000000000000000000000000000" > @@ -91,3 +93,7 @@ class S390CCWVirtioMachine(Test): > exec_command_and_wait_for_pattern(self, > 'cat /sys/bus/pci/devices/0005\:00\:00.0/subsystem_device', > '0x0001') > + # check fid propagation > + exec_command_and_wait_for_pattern(self, > + 'cat /sys/bus/pci/devices/000a\:00\:00.0/function_id', > + '0x0000000c')