From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 5/7] block-copy: add QemuMutex lock for BlockCopyCallState list
Date: Tue, 25 May 2021 12:58:52 +0200 [thread overview]
Message-ID: <72b73ec2-da87-f672-6a7d-bba008df9871@redhat.com> (raw)
In-Reply-To: <cd5dd350-cb83-c2d0-c937-393191d6c7f4@redhat.com>
On 21/05/2021 17:01, Paolo Bonzini wrote:
> On 20/05/21 17:30, Vladimir Sementsov-Ogievskiy wrote:
>> 18.05.2021 13:07, Emanuele Giuseppe Esposito wrote:
>>> As for BlockCopyTask, add a lock to protect BlockCopyCallState
>>> ret and sleep_state fields. Also move ret, finished and cancelled
>>> in the OUT fields of BlockCopyCallState.
>>>
>>> Here a QemuMutex is used to protect QemuCoSleep field, since it
>>> can be concurrently invoked also from outside threads.
Actually I don't even protect it here, I should have deleted the above
line. I left a TODO for the QemuCoSleep field.
>>>
>>> .finished, .cancelled and reads to .ret and .error_is_read will be
>>> protected in the following patch.
>>>
>>> .sleep state is handled in the series "coroutine: new sleep/wake API"
>>
>> Could we live with one mutex for all needs? Why to add one more?
>
> This patch should just go away; the QemuMutex will not be needed once
> QemuCoSleep is thread safe, while right now it is still racy.
At this point, I would just rename the other lock (tasks_lock) in "lock"
or "state_lock", and substitute it in the calls_lock usages of this
patch. Depending on how it comes out, I may merge this with the previous
patch.
Thank you,
Emanuele
next prev parent reply other threads:[~2021-05-25 10:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 10:07 [PATCH v2 0/7] block-copy: protect block-copy internal structures Emanuele Giuseppe Esposito
2021-05-18 10:07 ` [PATCH v2 1/7] block-copy: streamline choice of copy_range vs. read/write Emanuele Giuseppe Esposito
2021-05-20 14:42 ` Vladimir Sementsov-Ogievskiy
2021-05-20 15:06 ` Emanuele Giuseppe Esposito
2021-05-20 15:24 ` Vladimir Sementsov-Ogievskiy
2021-05-21 15:10 ` Paolo Bonzini
2021-05-21 15:48 ` Vladimir Sementsov-Ogievskiy
2021-05-21 16:43 ` Paolo Bonzini
2021-05-21 17:51 ` Vladimir Sementsov-Ogievskiy
2021-05-27 8:20 ` Stefan Hajnoczi
2021-05-27 19:04 ` Paolo Bonzini
2021-05-18 10:07 ` [PATCH v2 2/7] block-copy: improve documentation of BlockCopyTask and BlockCopyState types and functions Emanuele Giuseppe Esposito
2021-05-20 15:00 ` Vladimir Sementsov-Ogievskiy
2021-05-20 15:15 ` Emanuele Giuseppe Esposito
2021-05-18 10:07 ` [PATCH v2 3/7] block-copy: move progress_set_remaining in block_copy_task_end Emanuele Giuseppe Esposito
2021-05-20 15:03 ` Vladimir Sementsov-Ogievskiy
2021-05-18 10:07 ` [PATCH v2 4/7] block-copy: add a CoMutex to the BlockCopyTask list Emanuele Giuseppe Esposito
2021-05-20 15:19 ` Vladimir Sementsov-Ogievskiy
2021-05-25 10:07 ` Emanuele Giuseppe Esposito
2021-05-25 10:25 ` Vladimir Sementsov-Ogievskiy
2021-05-26 14:58 ` Paolo Bonzini
2021-05-26 16:13 ` Vladimir Sementsov-Ogievskiy
2021-05-27 9:07 ` Stefan Hajnoczi
2021-05-18 10:07 ` [PATCH v2 5/7] block-copy: add QemuMutex lock for BlockCopyCallState list Emanuele Giuseppe Esposito
2021-05-20 15:30 ` Vladimir Sementsov-Ogievskiy
2021-05-21 15:01 ` Paolo Bonzini
2021-05-25 10:58 ` Emanuele Giuseppe Esposito [this message]
2021-05-26 14:49 ` Paolo Bonzini
2021-05-28 10:53 ` Paolo Bonzini
2021-05-18 10:07 ` [PATCH v2 6/7] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState Emanuele Giuseppe Esposito
2021-05-20 15:34 ` Vladimir Sementsov-Ogievskiy
2021-05-21 15:02 ` Paolo Bonzini
2021-05-21 15:53 ` Vladimir Sementsov-Ogievskiy
2021-05-21 15:56 ` Vladimir Sementsov-Ogievskiy
2021-05-21 16:47 ` Paolo Bonzini
2021-05-18 10:07 ` [PATCH v2 7/7] block-copy: protect BlockCopyState .method fields Emanuele Giuseppe Esposito
2021-05-21 17:10 ` Vladimir Sementsov-Ogievskiy
2021-05-25 10:18 ` Emanuele Giuseppe Esposito
2021-05-25 11:00 ` Vladimir Sementsov-Ogievskiy
2021-05-26 14:48 ` Paolo Bonzini
2021-05-26 17:18 ` Vladimir Sementsov-Ogievskiy
2021-05-28 10:24 ` Paolo Bonzini
2021-05-28 11:01 ` Paolo Bonzini
2021-05-28 11:52 ` Vladimir Sementsov-Ogievskiy
2021-05-28 12:44 ` Vladimir Sementsov-Ogievskiy
2021-05-20 13:47 ` [PATCH v2 0/7] block-copy: protect block-copy internal structures Vladimir Sementsov-Ogievskiy
2021-05-20 14:33 ` Emanuele Giuseppe Esposito
2021-05-27 10:31 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72b73ec2-da87-f672-6a7d-bba008df9871@redhat.com \
--to=eesposit@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).