From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF4EDC433DB for ; Wed, 24 Mar 2021 18:50:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B74161A10 for ; Wed, 24 Mar 2021 18:50:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B74161A10 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP8aQ-0007rd-LL for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 14:50:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP8Qk-0007fT-DU for qemu-devel@nongnu.org; Wed, 24 Mar 2021 14:40:34 -0400 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]:36537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP8Qi-0006tJ-MO for qemu-devel@nongnu.org; Wed, 24 Mar 2021 14:40:33 -0400 Received: by mail-oi1-x233.google.com with SMTP id c16so12955013oib.3 for ; Wed, 24 Mar 2021 11:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xyfaVHaOdWdgmJX8owG5vZ6lAjLL/K625YKUWH7rLCM=; b=K6QBCcYIuR+wBc2Zom/KokoIMIi9iVFDny7J7sjNYFNt4pVCYkAUjZ3gkCLzyL8rCk wxFq2U2KATbrrjY5/KJUAqE5Mkss0dMeCm1qrVNkctzShZZdgfn1ns2Otg60SXdiHLNz 7GB6EGWUPQByAngx/wMrvYqVGZmeUyx0+osBaEc8hrM94FMrwHrHs1EV4Voy+TdU8sc4 iAx0bgI7mSdskHomjvFnIMMo3XU7thzUhxMNstRRxpdCxLAw/ojiXgZBLrH9TTxXt+g/ mK9rzyPhBPtweeKVrtVTMVDdjFsKJHblxdGM/tttSRHbWNaCLw00ENMLb9ZYOK4bxOYX HA6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xyfaVHaOdWdgmJX8owG5vZ6lAjLL/K625YKUWH7rLCM=; b=m6BmgI68R1FnbK/BUnW/JZIOTtwKv+i7UjGgQBWHO9wy3pdm1bOyJZRRNA1cSO4XpF TINOxW/dE3LXiZIozoMBrzmohnjw1EY0P8sivOo4Gwun1renMHnxnO39dlkgecpV1MGP nGDJaZBKTBw497qGHmP5aBqZ0y9rZVEl1H5fWW/Kmzjcpx2Zr4O2s1+hOLXZ0pE7r7ta UNyT8eVUyPoQJhDxVralpcykMcbRFW2tzcQrrdNM26P+d2tL2PYk8jGwHuPAIpb/UNuF SmyAgsXRH1FmKABJlI7Yf86quIXA/rSj+9DUEgiAh8DM10fuVGwmYB9o0Trg5dmbsxvk 7ekA== X-Gm-Message-State: AOAM530nZxSA3cAMffaGg0DlVfIWFb6O5MKNu7E9mxPm0Hlo9equ4O6j bKlT4vylrmpXvbc4gUiLEIx2Og== X-Google-Smtp-Source: ABdhPJw0GyLGwkqG+qhh5CysMpNm+MCc0Gl+hMnbm5gE2Ym8tuXy0PnkhGm00W0qhgvkwKBqEgr+TA== X-Received: by 2002:aca:e187:: with SMTP id y129mr3206960oig.62.1616611230656; Wed, 24 Mar 2021 11:40:30 -0700 (PDT) Received: from [172.24.51.127] (168.189-204-159.bestelclientes.com.mx. [189.204.159.168]) by smtp.gmail.com with ESMTPSA id v1sm717840ooh.3.2021.03.24.11.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 11:40:30 -0700 (PDT) Subject: Re: [RFC v11 13/55] target/arm: split cpregs from tcg/helper.c To: Claudio Fontana , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210323151749.21299-1-cfontana@suse.de> <20210323154639.23477-6-cfontana@suse.de> From: Richard Henderson Message-ID: <72ef93a3-d6b6-70a9-a4fd-aa679a7b780e@linaro.org> Date: Wed, 24 Mar 2021 12:40:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210323154639.23477-6-cfontana@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x233.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Roman Bolshakov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/23/21 9:45 AM, Claudio Fontana wrote: > give them their own common module cpregs.c, and an interface cpregs.h. > Extract the raw cpustate list to its own module. > This is more or less needed for KVM too. > > For the tcg-specific registers, stuff them into tcg/cpregs.c > > As a result, the monster that is tcg/helper.c is a bit less scary, > and a lot of stuff is removed from cpu.h too, relegated to cpregs.h. > > Signed-off-by: Claudio Fontana > --- I would expect ARM_CP_* to move out of cpu.h. I don't see any use of the ARMCPRegInfo typedef remaining in cpu.h. Surely that should move to the new header. Otherwise, it's really nice to get so many lines out of helper.c. r~