From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: David Hildenbrand <david@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Hyman Huang <huangy81@chinatelecom.cn>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] memory: Fix incorrect calls of log_global_start/stop
Date: Tue, 18 Jan 2022 10:33:56 +0100 [thread overview]
Message-ID: <735e5238-bb70-506c-2551-4ed74519dacd@amsat.org> (raw)
In-Reply-To: <20211130080028.6474-1-peterx@redhat.com>
On 11/30/21 09:00, Peter Xu wrote:
> We should only call the log_global_start/stop when the global dirty track
> bitmask changes from zero<->non-zero.
>
> No real issue reported for this yet probably because no immediate user to
> enable both dirty rate measurement and migration at the same time. However
> it'll be good to be prepared for it.
>
> Fixes: 63b41db4bc ("memory: make global_dirty_tracking a bitmask")
> Cc: Hyman Huang <huangy81@chinatelecom.cn>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> softmmu/memory.c | 27 ++++++++++++++-------------
> 1 file changed, 14 insertions(+), 13 deletions(-)
Thanks, queued via memory-api (adding Cc: qemu-stable).
prev parent reply other threads:[~2022-01-18 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 8:00 [PATCH] memory: Fix incorrect calls of log_global_start/stop Peter Xu
2021-11-30 15:03 ` David Hildenbrand
2021-12-01 6:07 ` Peter Xu
2022-01-18 9:33 ` Philippe Mathieu-Daudé via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=735e5238-bb70-506c-2551-4ed74519dacd@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=huangy81@chinatelecom.cn \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).