From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C05BC4743C for ; Mon, 21 Jun 2021 23:43:29 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07760611BD for ; Mon, 21 Jun 2021 23:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07760611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvTZf-0007yZ-QS for qemu-devel@archiver.kernel.org; Mon, 21 Jun 2021 19:43:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvTPc-0000FA-MF for qemu-devel@nongnu.org; Mon, 21 Jun 2021 19:33:04 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:33663) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvTPa-0005yE-VX for qemu-devel@nongnu.org; Mon, 21 Jun 2021 19:33:04 -0400 Received: by mail-pf1-x430.google.com with SMTP id p13so14939151pfw.0 for ; Mon, 21 Jun 2021 16:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Oyxsog59mQzcob3ThA45aZX5FEIGm5wl+am07ke/Bac=; b=QMdVLOhrHFecqiSIAPW0KmH81Ibr8z3Kg8vUVT4HfAsz4aupXfro9PnBEe51ArbFXa A6NJHUDFbZzOtD9LnlFxMHZfwPcFIcQNHpTRkzz7RBEsS9/sIM7IAAtXin3eduR5mpR3 gCytk5Q26TYo3HE9Il/rKV8+MzXt/KFdEx866PPD5aXjYOAZivW2Xg+TbQbJ0xOgHCA2 WW7u5BuGwPU9VRj5tKonGUhcXg06TAWShU9TQl+widvyccookGrqoDbnn4Db91BQEu8Q 0aRL2cnmpoe7n/5vW2KoTxcPWT5MmtlCZhST+yhhQlccLHtYw/K0AaX6Ocx4KL4WnD/1 Tq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Oyxsog59mQzcob3ThA45aZX5FEIGm5wl+am07ke/Bac=; b=a9K/pbrN35B3zBdjBqVJ55VZVeEdVelNmMNXsJUvy8+y37DXs3gp+a0OFUb6eq/nP9 fdWRbFPCqDUWt+NPTo8Sbe7vdNlz+0gLn7dKoehoe6DT7VU525rZBaHGrcJUS0UVy097 4c2cefT9rPivZE/iWIeXf+9THosXPiekEnA0AStVS3MzZfq/xr21gXcQPBzwvaLPFlXb ETE4ZTbRHBQNCO6x/NsB0NM9CHFqfp3UavnRnEPe6TSsH6wVYm+VjDYXxM8m5HTpj8NH QHz+cJzERsTA7GvY8muK29W3hy1kjED3ecaNSCg+tP2+oSQIaQn5yBDmEh3Jku3zdCYz nK5g== X-Gm-Message-State: AOAM533u3vSEshSDpalIynEVspMzkgXwxYau0DvX1AC/v55gUWSxeinC BhciI2s41stgqIEKI1co5ToajiizdW8acQ== X-Google-Smtp-Source: ABdhPJzGOCaSGnaJQErF+ASl38qNUfmpNTQRSWqme+xqIP/UwGANtgFfzWl6CaFpwa1ZtigCj8MqcA== X-Received: by 2002:a63:d84b:: with SMTP id k11mr891604pgj.372.1624318381453; Mon, 21 Jun 2021 16:33:01 -0700 (PDT) Received: from [192.168.1.11] ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id l7sm17662465pgb.19.2021.06.21.16.33.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 16:33:01 -0700 (PDT) Subject: Re: [PATCH v2 02/11] target/cris: Replace DISAS_TB_JUMP with DISAS_NORETURN To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210620213249.1494274-1-richard.henderson@linaro.org> <20210620213249.1494274-3-richard.henderson@linaro.org> <42a219d5-8ca3-b15b-7b79-2d57fd23cdf5@amsat.org> From: Richard Henderson Message-ID: <73860f87-17ac-fd76-b051-bc544fe55a07@linaro.org> Date: Mon, 21 Jun 2021 16:32:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <42a219d5-8ca3-b15b-7b79-2d57fd23cdf5@amsat.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edgar.iglesias@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/21/21 1:01 PM, Philippe Mathieu-Daudé wrote: > On 6/20/21 11:32 PM, Richard Henderson wrote: >> The only semantic of DISAS_TB_JUMP is that we've done goto_tb, >> which is the same as DISAS_NORETURN -- we've exited the tb. >> >> Signed-off-by: Richard Henderson >> --- >> target/cris/translate.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/target/cris/translate.c b/target/cris/translate.c >> index bed7a7ed10..2ff4319dd1 100644 >> --- a/target/cris/translate.c >> +++ b/target/cris/translate.c >> @@ -55,7 +55,6 @@ >> /* is_jmp field values */ >> #define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */ >> #define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */ >> -#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */ >> #define DISAS_SWI DISAS_TARGET_3 > > Can we #define DISAS_SWI DISAS_TARGET_2 in the same commit? No point. It goes away in patch 4. r~